From 44292cb9abc47a57fca44762d6f048477da2b6ea Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 5 Aug 2026 18:24:09 +0000 Subject: [PATCH 1/2] CI: add --features cycle-driver to the supervisor step (30 unrun falsifiers) `cycle-driver` is a SEPARATE feature that `supervisor` does not imply, so the supervisor step -- despite being this crate's own step -- never compiled `cycle_driver`, the three `probe_ignition*` / `d_ign_b_lenses` test binaries, or any of #879's loop-closure contract. Measured on this tree, not inferred: --features supervisor 13 tests --features supervisor,cycle-driver 43 tests, 0 failed The 30 in the gap include `probe_ignition_64k_start_at_full_population` -- the 65,536-owner / 17-sealed headline canonized as E-64K-1TO1-OWNERS-IS-THE-MAIN-MODEL-1. It runs in 13.75 s and passes; it had simply never run anywhere but a developer machine. #891 recorded this gap and deliberately did not touch the workflow. #898 closed the identical shape for callcenter (`--features query`) but not this one -- same arc, same defect class, one closed and one left open. One added feature closes it, and the new invocation is a strict superset of the old, so it cannot lose coverage. --- .github/workflows/rust-test.yml | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust-test.yml b/.github/workflows/rust-test.yml index 4e58c561..8d4851aa 100644 --- a/.github/workflows/rust-test.yml +++ b/.github/workflows/rust-test.yml @@ -139,8 +139,23 @@ jobs: # membrane failure (E-SEMANTIC-OS-CONVERGENCE-1). Flagged by # coderabbit on #634. Cheap: contract + ractor + the shader-driver # dev-dep, no lance/datafusion. - - name: Run supervisor tests (W2b real-owner probes) - run: cargo test --manifest-path crates/lance-graph-supervisor/Cargo.toml --features supervisor + # + # `cycle-driver` ADDED 2026-08-05. It is a SEPARATE feature that + # `supervisor` does not imply, so the step above — despite being the + # crate's own step — never compiled `cycle_driver`, the three + # `probe_ignition*` / `d_ign_b_lenses` test binaries, or any of the #879 + # loop-closure contract. Measured: `--features supervisor` runs 13 tests; + # `--features supervisor,cycle-driver` runs 43. The 30 in the gap include + # `probe_ignition_64k_start_at_full_population` — the 64k-owner / + # 17-sealed headline canonized as + # E-64K-1TO1-OWNERS-IS-THE-MAIN-MODEL-1. #891 recorded this gap and + # deliberately did not touch the workflow; #898 closed the same shape for + # callcenter but not this one. One added feature closes it. + # + # Verified locally before landing: 43 passed, 0 failed. Strict superset of + # what this step ran before, so it cannot lose coverage. + - name: Run supervisor tests (W2b real-owner probes + #879 cycle driver) + run: cargo test --manifest-path crates/lance-graph-supervisor/Cargo.toml --features supervisor,cycle-driver # bgz-tensor: workspace-EXCLUDED metric-algebraic codec crate (deps the # ndarray sibling checked out above + in-repo holograph). None of the # steps above reach it, so its 207 lib tests — including the V3 From c4296d50aba27ee4e536cdcfaeb9e34e623d29c3 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 5 Aug 2026 18:26:38 +0000 Subject: [PATCH 2/2] Cargo.lock: drop the stale blake3 entry under ndarray `ndarray` removed `blake3` as a dependency deliberately -- its Cargo.toml now carries "blake3 -- NO LONGER A DEPENDENCY. Do not re-add it.", with BLAKE3 moved in-tree to `src/hpc/blake3.rs` to break a `ndarray -> blake3 -> ndarray` cycle and to shed blake3's unconditional `cc` build-dependency. lance-graph's lockfile never caught up and still listed it. Cargo corrected it on its own during the supervisor test runs for the cycle-driver CI step; this commit just records that correction rather than leaving the tree dirty. Verified this reflects ndarray's DEFAULT branch (master @ 417f66a3), not the in-flight ndarray branch this session is also pushing -- a lock refresh that pinned lance-graph to an unmerged sibling state would be the wrong thing to commit, so that was checked before landing it. --- Cargo.lock | 1 - 1 file changed, 1 deletion(-) diff --git a/Cargo.lock b/Cargo.lock index 6141727c..32432459 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -6636,7 +6636,6 @@ dependencies = [ name = "ndarray" version = "0.17.2" dependencies = [ - "blake3", "fractal", "matrixmultiply", "num-complex",