Skip to content

index.d.ts: incorrect typing for validate function #28

Description

@jzabinski-dolios

For the validate function, index.d.ts declares:

validate(): void;

Here is the relevant code from index.js:

WasmModule.prototype.validate = function (options) {
var features = new Features(options || ({}));

index.d.ts is missing a description of the options parameter. Ferreting around in the code, it looks like elsewhere in index.d.ts, WasmFeatures is defined, which seems to be intended to match the WebAssembly feature list described here.

I think that index.d.ts should say:

validate(options?: WasmFeatures): void;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions