fixed feedback mistakes

Author: zakiaao-tech

Sprint-2/1-key-exercises/1-count.js

@@ -8,5 +8,5 @@ count = count + 1;
 
 
 
-Line 1 is a declaration and Line 3 is a statement that changes the value of the variable 'count' by adding 1 to its current value.
-The variable is changing from 0 to 1 after line 3 is executed after we used 'let' to declare the variable 'count' and then we used the = operator to assign the new value. 
+//Line 1 is a declaration and Line 3 is a statement that changes the value of the variable 'count' by adding 1 to its current value.
+//The variable is changing from 0 to 1 after line 3 is executed after we used 'let' to declare the variable 'count' and then we used the = operator to assign the new value. 

Sprint-2/1-key-exercises/3-paths.js

@@ -19,8 +19,12 @@ console.log(`The base part of ${filePath} is ${base}`);
 
 const dir = filePath.slice(0, lastSlashIndex);
 
+const ext = base.slice(base.lastIndexOf("."));
+
+
+console.log(dir);
+console.log(ext);
 
-const ext =  base.slice(45); 
 
 
 // https://www.google.com/search?q=slice+mdn

Sprint-2/1-key-exercises/4-random.js

@@ -11,17 +11,20 @@ console.log(num);
 // It will help to think about the order in which expressions are evaluated
 // Try logging the value of num and running the program several times to build an idea of what the program is doing
 
-Num represents a random whole number between the value of 'minimum' (1) and 'maximum' (100)
-By creating a constant variable called 'num' and assigning it the value of the expression, we can generate a random number within the mentioned range. 
-
-When running the program we have to understand how the expression works:
-
-we have to work out the parentheses first, maximum - minimum + 1, which is equal to 100 - 1 + 1 = 100.
-so: Math.floor(Math.random() *100) + 1
- Math.random() produces a pseudo-random decimal number that is greater than or equal to 0 but less than 1.
-
- Next, we need to multiply the result from Math.random() by 100. This may give us the result of a decimal between 0 and 100.
- Next step is to use Math.floor() wich then rounds down the decimal number to the nearest whole integer. This then means that the result will be a whole number between 0 and 99.
-But we want 1-100, so we add 1 to the result of Math.floor() this then changes the range to be inclusive of 1 and 100.
-After adding 1, we need to round down the number to the nearest interger, this is done by using Math.floor(). After this we will have a whole number between maximum and minimum.
-Therefore, the final result of num will be a random whole number between 1 and 100, inclusive.
+//Num represents a random whole number between the value of 'minimum' (1) and 'maximum' (100)
+//By creating a constant variable called 'num' and assigning it the value of the expression, we can generate a random number within the mentioned range. 
+
+//When running the program we have to understand how the expression works:
+
+//we have to work out the parentheses first, maximum - minimum + 1, which is equal to 100 - 1 + 1 = 100.
+//so: Math.floor(Math.random() *100) + 1
+// Math.floor is used 1 time and it happens before + minimum. Math.floor is used because when used Math.random() it produces a decimal number between 0 and 1.
+//The code needs a whole number because we are trying to get a number between 1 and 100, this is where Math.floor comes () comes in and removes the decimal part.
+//JavaScript works out  the expression inside Math.floor () first before + minimum. 
+ //Math.random() produces a pseudo-random decimal number that is greater than or equal to 0 but less than 1.
+
+ //Next, we need to multiply the result from Math.random() by 100. This may give us the result of a decimal between 0 and 100.
+ //Next step is to use Math.floor() wich then rounds down the decimal number to the nearest whole integer. This then means that the result will be a whole number between 0 and 99.
+//But we want 1-100, so we add 1 to the result of Math.floor() this then changes the range to be inclusive of 1 and 100.
+//After adding 1, we need to round down the number to the nearest interger, this is done by using Math.floor(). After this we will have a whole number between maximum and minimum.
+//Therefore, the final result of num will be a random whole number between 1 and 100, inclusive.

Sprint-2/2-mandatory-errors/0.js

@@ -1,6 +1,7 @@
-This is just an instruction for the first activity - but it is just for human consumption
-We don't 
+//This is just an instruction for the first activity - but it is just for human consumption
+//We don't 
+
 // want the computer to run these 2 lines - how can we solve this problem?
 
-We can add 2 forward slashes , by typing two forward slashes ( // ) at the beginning of the line, we can turn that line into a comment. This then means that the computer will completely ignore that line and not run it.
+//We can add 2 forward slashes , by typing two forward slashes ( // ) at the beginning of the line, we can turn both lines into a comment. This then means that the computer will completely ignore that line and not run it.
 

Sprint-2/2-mandatory-errors/1.js

@@ -6,10 +6,10 @@ console.log (age);
 
 
 
-const means that the variable age is a constant and cannot be reassigned. When we try to reassign the value of age by adding 1 to it, we get an error. 
-This is because we cannot change the value of a constant variable once we have created it. 
+//const means that the variable age is a constant and cannot be reassigned. When we try to reassign the value of age by adding 1 to it, we get an error. 
+//This is because we cannot change the value of a constant variable once we have created it. 
 
-If we want to change the value of age, we need to use let instead of consts when declaring the variable. this then allows us to reassign the value of age by adding 1 to it.
+//If we want to change the value of age, we need to use let instead of consts when declaring the variable. this then allows us to reassign the value of age by adding 1 to it.
 
 
 

Sprint-2/2-mandatory-errors/2.js

@@ -1,17 +1,17 @@
 // Currently trying to print the string "I was born in Bolton" but it isn't working...
 // what's the error ?
 
-error 
+//error 
 
-console.log(`I was born in ${cityOfBirth}`);
-const cityOfBirth = "Bolton";
+//console.log(`I was born in ${cityOfBirth}`);
+//const cityOfBirth = "Bolton";
 
-The reason there is an error is because we are using the wrong order, we are telling Javascript to print the value of cityOfBirth before creating a variable.
-So we need to create the variable first, this is because Javascript runs code from top to bottom, so a variable that is declared with const needs to be declared before using it.
+//The reason there is an error is because we are using the wrong order, we are telling Javascript to print the value of cityOfBirth before creating a variable.
+//So we need to create the variable first, this is because Javascript runs code from top to bottom, so a variable that is declared with const needs to be declared before using it.
 
 
 
-right way
+//right way
 
 const cityOfBirth = "Bolton";
 console.log (`I was born in ${cityOfBirth}`); 

Sprint-2/2-mandatory-errors/3.js

@@ -11,12 +11,14 @@ const last4Digits = cardNumber.slice(-4);
 
 console.log(last4Digits);
 
-I think that Javascript will give an error because .slice() is normally used with strings, and cardNumber is currently a number.
-const cardNumber = 4533787178994213; does not have any quotation marks, so Javascript will treat it as a number. 
+//I think that Javascript will give an error because .slice() is normally used with strings, and cardNumber is currently a number.
+//const cardNumber = 4533787178994213; does not have any quotation marks, so Javascript will treat it as a number. 
 
-When run with console.log(last4Digits); we get --> TypeError : cardNumber.slice is not a function 
+//When run with console.log(last4Digits); we get --> TypeError : cardNumber.slice is not a function 
 
-.slice is a method used with strings and we need to make cardNumber into a string by adding quotation marks.I
+//.slice is a method used with strings and we need to make cardNumber into a string by adding quotation marks.I
 
-const cardNumber = 4533787178994213 to const cardNumber = "4533787178994213";
-Now cardNumber is a string, then we can re run the code with console.log(last4Digits); to get the correct code.
+//we can change the expression by making it intoa string by doing --> const last4Digits = String(cardnumber).slice(-4);
+//String(cardNumber) changes the number into a string and .slice(-4) takes the last 4 characters and stores it in last4Digits.
+//const cardNumber = 4533787178994213 to const cardNumber = "4533787178994213";
+//Now cardNumber is a string, then we can re run the code with console.log(last4Digits); to get the correct code.

Sprint-2/2-mandatory-errors/4.js

@@ -9,4 +9,4 @@ console.log(hour24ClockTime);
 
 
 
-Variable names cannot start with a number as Javascript doesnt allow it, it can contan number inside the variable but not at the beginning.
+//Variable names cannot start with a number as Javascript doesn't allow it, it can contain a number inside the variable but not at the beginning.

Sprint-2/3-mandatory-interpret/1-percentage-change.js

@@ -2,7 +2,7 @@ let carPrice = "10,000";
 let priceAfterOneYear = "8,543";
 
 carPrice = Number(carPrice.replaceAll(",", ""));
-priceAfterOneYear = Number(priceAfterOneYear.replaceAll("," ""));
+priceAfterOneYear = Number(priceAfterOneYear.replaceAll("," ,""));
 
 const priceDifference = carPrice - priceAfterOneYear;
 const percentageChange = (priceDifference / carPrice) * 100;
@@ -12,13 +12,19 @@ console.log(`The percentage change is ${percentageChange}`);
 // Read the code and then answer the questions below
 
 // a) How many function calls are there in this file? Write down all the lines where a function call is made
- There are 5 function calls, two function calls on line 4 = Number(...) and replaceAll(...) two more on line 5 = Number(...) and replaceAll(...) and finally on line 10 = console.log(...)
+ //>
+// There are 5 function calls, two function calls on line 4 = Number(...) and replaceAll(...) two more on line 5 = Number(...) and replaceAll(...) and finally on line 10 = console.log(...)
+
 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
-SyntaxError: missing a comma to separate the arguments
+
+//>SyntaxError: missing a comma to separate the arguments
+
 // c) Identify all the lines that are variable reassignment statements
-carPrice = Number(carPrice.replaceAll(",", "")); and priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));
+//>carPrice = Number(carPrice.replaceAll(",", "")); and priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));
+
 // d) Identify all the lines that are variable declarations
-There are 4 variable declarations- 1) let carPrice = "10,000"; 2) let priceAfterOneYear = "8,543"; 
-3) const priceDifference = carPrice-priceAfterOneYear; 4) const percentageChange = (priceDifferenc/carPrice)* 100;
+//>There are 4 variable declarations- 1) let carPrice = "10,000"; 2) let priceAfterOneYear = "8,543"; 
+//3) const priceDifference = carPrice-priceAfterOneYear; 4) const percentageChange = (priceDifferenc/carPrice)* 100;
+
 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
-Number(carPrice.replaceAll(",", "")); is a string and the expression removes the comma from "10,000" and converts "10000" from a string into the number 10000.
+//>Number(carPrice.replaceAll(",", "")); is a string and the expression removes the comma from "10,000" and converts "10000" from a string into the number 10000.

Sprint-2/3-mandatory-interpret/2-time-format.js

@@ -1,4 +1,4 @@
-const movieLength = 8784; // length of movie in seconds
+const movieLength =  90.5; // length of movie in seconds
 
 const remainingSeconds = movieLength % 60;
 const totalMinutes = (movieLength - remainingSeconds) / 60;
@@ -12,20 +12,29 @@ console.log(result);
 // For the piece of code above, read the code and then answer the following questions
 
 // a) How many variable declarations are there in this program?
-6 variable Declarations, every const creates a new variable.
+//>6 variable Declarations, every const creates a new variable.
+
 // b) How many function calls are there?
-1 function calls is console.log() as it is a function being called and told to do the job
+//>1 function calls is console.log() as it is a function being called and told to do the job
+
 // c) Using documentation, explain what the expression movieLength % 60 represents
 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators
 
-movieLength % 60 means finding the remainder after dividing movieLength by 60. movieLength = 8784 so we need to do: 8784 % 60 = 146.4 and the nearest whole integer is 146. 
-So there are 146 complete groups of 60. we then multiply; 146 x 60= 8760 --> 8784 - 8760 = 24 so 8784 % 60 = 24 and therefore remainingSeconds becomes 24.
+//>movieLength % 60 means finding the remainder after dividing movieLength by 60. movieLength = 8784 so we need to do: 8784 % 60 = 146.4 and the nearest whole integer is 146. 
+//So there are 146 complete groups of 60. we then multiply; 146 x 60= 8760 --> 8784 - 8760 = 24 so 8784 % 60 = 24 and therefore remainingSeconds becomes 24.
+//8784/60 = 146.4. and 8784 % 60 = 24 as this is the remainder.
 
 // d) Interpret line 4, what does the expression assigned to totalMinutes mean?
-const totalMinutes = (movieLength - remainingSeconds) / 60 ---> if we break it down -> movieLength = 8784 remainingSeconds = 24
-we then subtract remainingSeconds from movieLength= 8784 -24 = 8670. we then have to divide it by 60 which gives us 8760 / 60 = 146. we divide because there is 60 seconds in one minute, and right now we are converting seconds into minutes.
+//>const totalMinutes = (movieLength - remainingSeconds) / 60 ---> if we break it down -> movieLength = 8784 remainingSeconds = 24
+//we then subtract remainingSeconds from movieLength= 8784 -24 = 8670. we then have to divide it by 60 which gives us 8760 / 60 = 146. we divide because there is 60 seconds in one minute, and right now we are converting seconds into minutes.
+
 // e) What do you think the variable result represents? Can you think of a better name for this variable?
-The result variable will show us he complete results from our calculations of = totalHours:remainingMinutes:remainingSeconds.
-result = 2:26:24
+//>The result variable will show us he complete results from our calculations of = totalHours:remainingMinutes:remainingSeconds.
+//result = 2:26:24
+
 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
-I tested differnet codes: 7965 and I got the result 2:12:45 and i also tried : 2654 and got 0:44:14.
+//>I tested differnet codes: 7965 and I got the result 2:12:45 and i also tried : 2654 and got 0:44:14.
+
+//> suggestions to run code - 59 gives us 0:0:59 > less than 60 seconds
+//-90 gives us 0:-1:-30 - not valid as the code works properly for non-negative whole numbers
+//90.5 gives us 0:1:30.5 > this tells us 60 goes into 90.5 once and 30.5 is the remainder