Skip to content

Broken lanczos mask using clang16 #129

Description

@Nomoresleep

OS: Arch-Linux
Compiler: clang16 (blobbed)

Description:
When running the lanczos function from ffx_fsr2.cpp clang uses an integer based version of abs and implicitly converts the value argument to an integer format using cvtss2si and back to float with cvtsi2ss afterwards. This causes the full lanczos kernel mask to be basically useless, turning FSR output into a blur.

Resolution: It should probably use absf instead.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions