diff --git a/packages/assets-controllers/CHANGELOG.md b/packages/assets-controllers/CHANGELOG.md index 9df82a17e9b..227acad7e25 100644 --- a/packages/assets-controllers/CHANGELOG.md +++ b/packages/assets-controllers/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Set `persist: false` on state metadata for legacy assets controllers so their state is no longer written to disk (`TokensController`, `CurrencyRateController`, `TokenRatesController`, `TokenBalancesController`, `AccountTrackerController`, `MultichainAssetsController`, `MultichainAssetsRatesController`, `MultichainBalancesController`) ([#9842](https://github.com/MetaMask/core/pull/9842)) - Bump `@metamask/transaction-controller` from `^69.5.0` to `^69.5.2` ([#9798](https://github.com/MetaMask/core/pull/9798), [#9823](https://github.com/MetaMask/core/pull/9823)) - Bump `@metamask/accounts-controller` from `^39.0.7` to `^39.1.0` ([#9807](https://github.com/MetaMask/core/pull/9807)) diff --git a/packages/assets-controllers/src/AccountTrackerController.test.ts b/packages/assets-controllers/src/AccountTrackerController.test.ts index 0f4efc6fae6..9a9db94b6fd 100644 --- a/packages/assets-controllers/src/AccountTrackerController.test.ts +++ b/packages/assets-controllers/src/AccountTrackerController.test.ts @@ -2042,13 +2042,7 @@ describe('AccountTrackerController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "accountsByChainId": { - "0x1": {}, - }, - } - `); + ).toMatchInlineSnapshot(`{}`); }); }); diff --git a/packages/assets-controllers/src/AccountTrackerController.ts b/packages/assets-controllers/src/AccountTrackerController.ts index 3606dbbd1c2..7b887f96b6c 100644 --- a/packages/assets-controllers/src/AccountTrackerController.ts +++ b/packages/assets-controllers/src/AccountTrackerController.ts @@ -153,7 +153,7 @@ export type AccountTrackerControllerState = { const accountTrackerMetadata: StateMetadata = { accountsByChainId: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, diff --git a/packages/assets-controllers/src/CurrencyRateController.test.ts b/packages/assets-controllers/src/CurrencyRateController.test.ts index cc4abc7f893..4de6f52caf6 100644 --- a/packages/assets-controllers/src/CurrencyRateController.test.ts +++ b/packages/assets-controllers/src/CurrencyRateController.test.ts @@ -2326,18 +2326,7 @@ describe('CurrencyRateController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "currencyRates": { - "ETH": { - "conversionDate": 0, - "conversionRate": 0, - "usdConversionRate": null, - }, - }, - "currentCurrency": "usd", - } - `); + ).toMatchInlineSnapshot(`{}`); }); it('exposes expected state to UI', () => { diff --git a/packages/assets-controllers/src/CurrencyRateController.ts b/packages/assets-controllers/src/CurrencyRateController.ts index 5c4ac92587a..ca443a5dbe7 100644 --- a/packages/assets-controllers/src/CurrencyRateController.ts +++ b/packages/assets-controllers/src/CurrencyRateController.ts @@ -80,13 +80,13 @@ export type CurrencyRateMessenger = Messenger< const metadata: StateMetadata = { currentCurrency: { includeInStateLogs: true, - persist: true, + persist: false, includeInDebugSnapshot: true, usedInUi: true, }, currencyRates: { includeInStateLogs: true, - persist: true, + persist: false, includeInDebugSnapshot: true, usedInUi: true, }, diff --git a/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.test.ts b/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.test.ts index 463e4a2e1e2..a4dfc4b08f8 100644 --- a/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.test.ts +++ b/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.test.ts @@ -2212,13 +2212,7 @@ describe('MultichainAssetsController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "accountsAssets": {}, - "allIgnoredAssets": {}, - "assetsMetadata": {}, - } - `); + ).toMatchInlineSnapshot(`{}`); }); it('exposes expected state to UI', () => { diff --git a/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.ts b/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.ts index 5b4909715b1..6506d4d5b6b 100644 --- a/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.ts +++ b/packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.ts @@ -159,19 +159,19 @@ const assetsControllerMetadata: StateMetadata = { assetsMetadata: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, accountsAssets: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, allIgnoredAssets: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, diff --git a/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.test.ts b/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.test.ts index 0aea388308d..d353631b4f9 100644 --- a/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.test.ts +++ b/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.test.ts @@ -1613,11 +1613,7 @@ describe('MultichainAssetsRatesController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "conversionRates": {}, - } - `); + ).toMatchInlineSnapshot(`{}`); }); it('exposes expected state to UI', () => { diff --git a/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts b/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts index 49306a3c4c9..9fefbaa7ffd 100644 --- a/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts +++ b/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts @@ -153,7 +153,7 @@ export type MultichainAssetsRatesPollingInput = { const metadata: StateMetadata = { conversionRates: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: true, usedInUi: true, }, diff --git a/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.test.ts b/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.test.ts index 9b94452292b..94e4412766d 100644 --- a/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.test.ts +++ b/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.test.ts @@ -1040,11 +1040,7 @@ describe('MultichainBalancesController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "balances": {}, - } - `); + ).toMatchInlineSnapshot(`{}`); }); it('exposes expected state to UI', () => { diff --git a/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.ts b/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.ts index 6c10bd9338a..2d028153085 100644 --- a/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.ts +++ b/packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.ts @@ -126,7 +126,7 @@ const balancesControllerMetadata: StateMetadata { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "tokenBalances": {}, - } - `); + ).toMatchInlineSnapshot(`{}`); }); it('exposes expected state to UI', () => { diff --git a/packages/assets-controllers/src/TokenBalancesController.ts b/packages/assets-controllers/src/TokenBalancesController.ts index d0afde3cc57..0ec5ca0cf85 100644 --- a/packages/assets-controllers/src/TokenBalancesController.ts +++ b/packages/assets-controllers/src/TokenBalancesController.ts @@ -129,7 +129,7 @@ export function mergeUpdateBalancesOptions( const metadata: StateMetadata = { tokenBalances: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, diff --git a/packages/assets-controllers/src/TokenRatesController.test.ts b/packages/assets-controllers/src/TokenRatesController.test.ts index 818da8ac738..92def4dbed1 100644 --- a/packages/assets-controllers/src/TokenRatesController.test.ts +++ b/packages/assets-controllers/src/TokenRatesController.test.ts @@ -1407,11 +1407,7 @@ describe('TokenRatesController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "marketData": {}, - } - `); + ).toMatchInlineSnapshot(`{}`); }); }); diff --git a/packages/assets-controllers/src/TokenRatesController.ts b/packages/assets-controllers/src/TokenRatesController.ts index a27105de668..1c65bf3718d 100644 --- a/packages/assets-controllers/src/TokenRatesController.ts +++ b/packages/assets-controllers/src/TokenRatesController.ts @@ -161,7 +161,7 @@ export type TokenRatesControllerMessenger = Messenger< const tokenRatesControllerMetadata: StateMetadata = { marketData: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, diff --git a/packages/assets-controllers/src/TokensController.test.ts b/packages/assets-controllers/src/TokensController.test.ts index 6819d2d9896..57ace47d888 100644 --- a/packages/assets-controllers/src/TokensController.test.ts +++ b/packages/assets-controllers/src/TokensController.test.ts @@ -4025,13 +4025,7 @@ describe('TokensController', () => { controller.metadata, 'persist', ), - ).toMatchInlineSnapshot(` - { - "allDetectedTokens": {}, - "allIgnoredTokens": {}, - "allTokens": {}, - } - `); + ).toMatchInlineSnapshot(`{}`); }); }); diff --git a/packages/assets-controllers/src/TokensController.ts b/packages/assets-controllers/src/TokensController.ts index ca22af31657..dc7d42f1321 100644 --- a/packages/assets-controllers/src/TokensController.ts +++ b/packages/assets-controllers/src/TokensController.ts @@ -110,19 +110,19 @@ export type TokensControllerState = { const metadata: StateMetadata = { allTokens: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, allIgnoredTokens: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, }, allDetectedTokens: { includeInStateLogs: false, - persist: true, + persist: false, includeInDebugSnapshot: false, usedInUi: true, },