fix: revert change to SubStats population in error reports

doesn't line up properly with other rejection stats

Author: georgeRobertson

src/dve/pipeline/pipeline.py

@@ -894,18 +894,14 @@ def error_report(
                 .agg(pl.col("Count").sum())  # type: ignore
                 .iter_rows(named=True)
             }
-            submission_rejections = err_types.get(
-                ErrorReportCategories.FILE_REJECTION.reporting_name, 0
-            )
             sub_stats = SubmissionStatisticsRecord(
                 submission_id=submission_info.submission_id,
                 record_count=submission_status.number_of_records,
-                number_submission_rejections=submission_rejections,
-                number_record_rejections=(
-                    submission_status.number_of_records
-                    if submission_rejections > 0 else err_types.get(  # type: ignore
-                        ErrorReportCategories.RECORD_REJECTION.reporting_name, 0
-                    )
+                number_submission_rejections=err_types.get(
+                    ErrorReportCategories.FILE_REJECTION.reporting_name, 0
+                ),
+                number_record_rejections=err_types.get(
+                    ErrorReportCategories.RECORD_REJECTION.reporting_name, 0
                 ),
                 number_warnings=err_types.get(ErrorReportCategories.WARNING.reporting_name, 0),
             )

tests/features/animals.feature

@@ -55,5 +55,5 @@ Feature: Pipeline tests using the animal dataset
             | parameter                    | value |
             | record_count                 | 7     |
             | number_submission_rejections | 1     |
-            | number_record_rejections     | 7     |
+            | number_record_rejections     | 2     |
             | number_warnings              | 1     |

tests/features/movies.feature

@@ -42,7 +42,7 @@ Feature: Pipeline tests using the movies dataset
             | parameter                    | value |
             | record_count                 | 5     |
             | number_submission_rejections | 1     |
-            | number_record_rejections     | 5     |
+            | number_record_rejections     | 3     |
             | number_warnings              | 2     |
         And the error aggregates are persisted
 
@@ -81,7 +81,7 @@ Feature: Pipeline tests using the movies dataset
             | parameter                    | value |
             | record_count                 | 5     |
             | number_submission_rejections | 1     |
-            | number_record_rejections     | 5     |
+            | number_record_rejections     | 3     |
             | number_warnings              | 2     |
         And the error aggregates are persisted