From 36dc4daa4f00f6d6863679e35586d2437de7dcc7 Mon Sep 17 00:00:00 2001
From: thatcomputerguy0101 <thatcomputerguy0101@gmail.com>
Date: Fri, 31 Jul 2026 00:25:17 -0400
Subject: [PATCH] Add java wrapper for compute_uncertainty

---
 .../java/org/photonvision/mrcal/MrCalJNI.java | 96 +++++++++++++++++++
 1 file changed, 96 insertions(+)

diff --git a/src/main/java/org/photonvision/mrcal/MrCalJNI.java b/src/main/java/org/photonvision/mrcal/MrCalJNI.java
index dc40a2d..d6811a4 100644
--- a/src/main/java/org/photonvision/mrcal/MrCalJNI.java
+++ b/src/main/java/org/photonvision/mrcal/MrCalJNI.java
@@ -21,6 +21,7 @@
 import java.util.Arrays;
 import java.util.List;
 import org.opencv.core.Point;
+import org.opencv.core.Point3;
 import org.wpilib.math.geometry.Pose3d;
 import org.wpilib.math.geometry.Rotation3d;
 import org.wpilib.math.geometry.Translation3d;
@@ -337,6 +338,30 @@ private static double[] makeObservations(
         return packedObservations;
     }
 
+    /**
+     * Convert from WPILib poses to a raw RT array
+     *
+     * @return array of size [numObservations * 6] where each group of 6 is (rvec[0], rvec[1],
+     *     rvec[2], tvec[0], tvec[1], tvec[2]) for the
+     */
+    private static double[] observationPosesToRtRef(List<Pose3d> observationPoses) {
+        double[] ret = new double[observationPoses.size() * 6];
+
+        for (int i = 0; i < observationPoses.size(); i++) {
+            var pose = observationPoses.get(i);
+            var r = pose.getRotation().toVector();
+            var t = pose.getTranslation().toVector();
+            ret[i * 6 + 0] = r.get(0);
+            ret[i * 6 + 1] = r.get(1);
+            ret[i * 6 + 2] = r.get(2);
+            ret[i * 6 + 3] = t.get(0);
+            ret[i * 6 + 4] = t.get(1);
+            ret[i * 6 + 5] = t.get(2);
+        }
+
+        return ret;
+    }
+
     /**
      * High-level wrapper for camera calibration using mrcal.
      *
@@ -395,4 +420,75 @@ public static MrCalResult calibrateCamera(
 
         return results;
     }
+
+    /**
+     * High-level wrapper for computing uncertainty using mrcal.
+     *
+     * <p>Converts detected chessboard corners and their detection levels into a packed double array.
+     * Converts observation poses into a packed double array. Then calls {@link
+     * #mrcal_calibrate_camera} to perform calibration. Each corner's detection level is converted to
+     * a weight (0.5^level), and negative levels indicate undetected corners.
+     *
+     * @param observations An iterator of observations, each containing a list of corner locations,
+     *     decimation levels, and optional corner ids
+     * @param intrinsics Lens intrinsics from the calibration
+     * @param observationPoses Estimated pose of the calibration board in each snapshot
+     * @param boardWidth Number of internal corners horizontally
+     * @param boardHeight Number of internal corners vertically
+     * @param boardSpacing Physical spacing between corners (meters)
+     * @param imageWidth Image width in pixels
+     * @param imageHeight Image height in pixels
+     * @param sampleGridWidth Width of the generated sample grid
+     * @param sampleGridHeight Height of the generated sample grid
+     * @param warpX The x-component of lens distortion warp, or zero if no warp was estimated.
+     * @param warpY The y-component of lens distortion warp
+     * @return
+     */
+    public static Point3[] computeUncertainty(
+            List<MrCalObservation> observations,
+            double[] intrinsics,
+            List<Pose3d> observationPoses,
+            int boardWidth,
+            int boardHeight,
+            double boardSpacing,
+            int imageWidth,
+            int imageHeight,
+            int sampleGridWidth,
+            int sampleGridHeight,
+            double warpX,
+            double warpY) {
+        if (observations.size() != observationPoses.size()) {
+            // Mismatched sizes
+            return null;
+        }
+
+        var packedObservations = makeObservations(observations, boardWidth, boardHeight);
+
+        var packedResult =
+                compute_uncertainty(
+                        packedObservations,
+                        intrinsics,
+                        observationPosesToRtRef(observationPoses),
+                        boardWidth,
+                        boardHeight,
+                        boardSpacing,
+                        imageWidth,
+                        imageHeight,
+                        sampleGridWidth,
+                        sampleGridHeight,
+                        warpX,
+                        warpY);
+
+        var result = new Point3[sampleGridWidth * sampleGridHeight];
+
+        if (packedResult == null) {
+            return null;
+        }
+
+        for (int i = 0; i < result.length; i++) {
+            result[i] = new Point3(packedResult[i * 3], packedResult[i * 3 + 1], packedResult[i * 3 + 2]);
+        }
+
+        return result;
+    }
 }