From 25b2aae7737a59f33ab56f9e3dbbff3d282c5b76 Mon Sep 17 00:00:00 2001 From: deepshekhardas Date: Mon, 17 Aug 2026 10:32:59 +0530 Subject: [PATCH] fix: reject multi-character separators in split Character-by-character comparison silently returned the unsplit string for multi-character separators. Raise ValueError instead. Fixes #14649 --- strings/split.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/strings/split.py b/strings/split.py index ed194ec69c2f..b7dbbf1b2d3d 100644 --- a/strings/split.py +++ b/strings/split.py @@ -17,8 +17,16 @@ def split(string: str, separator: str = " ") -> list: >>> split(";abbb;;c;", separator=';') ['', 'abbb', '', 'c', ''] + + >>> split("a--b--c", separator="--") + Traceback (most recent call last): + ... + ValueError: separator must be a single character """ + if len(separator) != 1: + raise ValueError("separator must be a single character") + split_words = [] last_index = 0