Skip to content

Not compatible with scipy >=1.3.0 #8

Description

@hanslovsky

SciPy had breaking changes (without increasing the major version!!!) and previously deprecated aliases from scipy.misc were removed:

>>> import malis
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hanslovskyp/my-experiment/0/conda-env/lib/python3.6/site-packages/malis/__init__.py", line 1, in <module>
    from .malis import *
  File "malis/malis.pyx", line 3, in init malis.malis
ImportError: cannot import name comb

Two possible solutions:

  1. Update all affected import statements and set minimum version requirement for scipy dependency
  2. Set upper bound for scipy dependency

I think (1) is a better solution. I currently do not have the time for a PR (maybe in three weeks), but this could be helpful for others who observe the same issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions