Skip to content

DXMT: keep indexed draw base vertex signed #754

Description

@moreaki

Problem

The DXMT indexed draw path currently carries the indexed draw base vertex through unsigned fields.

D3D11's BaseVertexLocation is signed, and Metal's baseVertex argument is signed as well. Negative base vertices are legal. Reinterpreting the value through uint32_t can turn a valid negative base vertex into a very large positive offset before the command reaches the winemetal encoder.

Proposed fix

Keep the base vertex signed across the DXMT/winemetal command boundary:

  • DXMT_DRAW_INDEXED_ARGUMENTS::BaseVertex
  • wmtcmd_render_draw_indexed::base_vertex

Validation

Signed-off-by: Roberto Nibali rnibali@gmail.com

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions