Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.
This repository was archived by the owner on May 3, 2022. It is now read-only.

Streaming send hangs if 'close' event is emitted #56

Description

@rnett

If a stream passed to sendStream or any other of the streaming methods emits a close event and uses an end event instead of the end() method, the send method will hang. This is reproducible by sending a file read stream with emitClose = true, and is fixed by setting it to false. Oddly, this does not seem to come up in the artifact or cache toolkit libraries that use this, but I'm passing the stream directly to sendStream and not doing anything else to it. It can be reproduced by manually sending end and close to a PassThrough stream (in any order) as well. Note that calling end and emitting close works fine, it only happens when you emit end with emit() instead of calling the method.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions