Skip to content

Commit ca3b99a

Browse files
committed
build: forward data and package.json to strict_deps_test
Forward `data` and `package.json` to `strict_deps_test` in the `ts_project` macro. With `data` assets included in strict deps checks, the `@ts-ignore strict-deps` workarounds on markdown asset imports across CLI commands are no longer needed.
1 parent cbac34a commit ca3b99a

13 files changed

Lines changed: 6 additions & 24 deletions

File tree

packages/angular/cli/src/commands/add/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ import { NgAddSaveDependency, PackageManifest, PackageMetadata } from '../../pac
2929
import { assertIsError } from '../../utilities/error';
3030
import { isTTY } from '../../utilities/tty';
3131
import { VERSION } from '../../utilities/version';
32-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
33-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
3432
import longDescription from './long-description.md';
3533

3634
class CommandError extends Error {}

packages/angular/cli/src/commands/analytics/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ import {
1717
demandCommandFailureMessage,
1818
} from '../../command-builder/utilities/command';
1919
import { AnalyticsInfoCommandModule } from './info/cli';
20-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
21-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
2220
import longDescription from './long-description.md';
2321
import {
2422
AnalyticsDisableModule,

packages/angular/cli/src/commands/build/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import { ArchitectCommandModule } from '../../command-builder/architect-command-module';
1010
import { CommandModuleImplementation } from '../../command-builder/command-module';
1111
import { RootCommands } from '../command-config';
12-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
13-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
1412
import longDescription from './long-description.md';
1513

1614
export default class BuildCommandModule

packages/angular/cli/src/commands/cache/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import {
1919
} from '../../command-builder/utilities/command';
2020
import { CacheCleanModule } from './clean/cli';
2121
import { CacheInfoCommandModule } from './info/cli';
22-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
23-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
2422
import longDescription from './long-description.md';
2523
import { CacheDisableModule, CacheEnableModule } from './settings/cli';
2624

packages/angular/cli/src/commands/completion/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import { addCommandModuleToYargs } from '../../command-builder/utilities/command
1212
import { colors } from '../../utilities/color';
1313
import { hasGlobalCliInstall, initializeAutocomplete } from '../../utilities/completion';
1414
import { assertIsError } from '../../utilities/error';
15-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
16-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
1715
import longDescription from './long-description.md';
1816

1917
export default class CompletionCommandModule

packages/angular/cli/src/commands/config/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ import {
1717
} from '../../command-builder/command-module';
1818
import { getWorkspaceRaw, validateWorkspace } from '../../utilities/config';
1919
import { JSONFile, parseJson } from '../../utilities/json-file';
20-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
21-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
2220
import longDescription from './long-description.md';
2321

2422
interface ConfigCommandArgs {

packages/angular/cli/src/commands/deploy/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import { MissingTargetChoice } from '../../command-builder/architect-base-command-module';
1010
import { ArchitectCommandModule } from '../../command-builder/architect-command-module';
1111
import { CommandModuleImplementation } from '../../command-builder/command-module';
12-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
13-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
1412
import longDescription from './long-description.md';
1513

1614
export default class DeployCommandModule

packages/angular/cli/src/commands/lint/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import { MissingTargetChoice } from '../../command-builder/architect-base-command-module';
1010
import { ArchitectCommandModule } from '../../command-builder/architect-command-module';
1111
import { CommandModuleImplementation } from '../../command-builder/command-module';
12-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
13-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
1412
import longDescription from './long-description.md';
1513

1614
export default class LintCommandModule

packages/angular/cli/src/commands/new/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ import {
2020
} from '../../command-builder/schematics-command-module';
2121
import { VERSION } from '../../utilities/version';
2222
import { RootCommands } from '../command-config';
23-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
24-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
2523
import longDescription from './long-description.md';
2624

2725
interface NewCommandArgs extends SchematicsCommandArgs {

packages/angular/cli/src/commands/run/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import {
1616
Options,
1717
OtherOptions,
1818
} from '../../command-builder/command-module';
19-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
20-
// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
2119
import longDescription from './long-description.md';
2220

2321
export interface RunCommandArgs {

0 commit comments

Comments
 (0)