From 48a8216330af8d6cc20fa314500d0678bc1599c9 Mon Sep 17 00:00:00 2001 From: comphead Date: Mon, 6 Jul 2026 16:11:00 -0700 Subject: [PATCH 1/3] chore: Run agg tests with default ANSI flag --- .../scala/org/apache/comet/exec/CometAggregateSuite.scala | 5 ----- 1 file changed, 5 deletions(-) diff --git a/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala b/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala index ae14c68207..3ca757d7c2 100644 --- a/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala +++ b/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala @@ -43,11 +43,6 @@ import org.apache.comet.testing.{DataGenOptions, FuzzDataGenerator, ParquetGener class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper { import testImplicits._ - // Several aggregate tests exercise overflow behavior expected to wrap around silently; - // ANSI-mode variants opt in to ANSI explicitly via withSQLConf. - override protected def sparkConf: SparkConf = - super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false") - test("min/max floating point with negative zero") { val r = new Random(42) val schema = StructType( From aca5fe1c80e3e0b801d6668e7a44f60e4a47d6cc Mon Sep 17 00:00:00 2001 From: comphead Date: Mon, 6 Jul 2026 16:29:44 -0700 Subject: [PATCH 2/3] chore: Run agg tests with default ANSI flag --- .../test/scala/org/apache/comet/exec/CometAggregateSuite.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala b/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala index 3ca757d7c2..23b3d43959 100644 --- a/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala +++ b/spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala @@ -22,7 +22,6 @@ package org.apache.comet.exec import scala.util.Random import org.apache.hadoop.fs.Path -import org.apache.spark.SparkConf import org.apache.spark.sql.{CometTestBase, DataFrame, Row} import org.apache.spark.sql.catalyst.expressions.Cast import org.apache.spark.sql.catalyst.optimizer.EliminateSorts From 9c97f1888de909e4b058e96299ae4f194943b72c Mon Sep 17 00:00:00 2001 From: comphead Date: Mon, 6 Jul 2026 17:06:06 -0700 Subject: [PATCH 3/3] chore: Run tests with default ANSI flag --- .../src/test/scala/org/apache/comet/CometCastSuite.scala | 6 ------ .../test/scala/org/apache/comet/CometFuzzMathSuite.scala | 9 --------- 2 files changed, 15 deletions(-) diff --git a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala index 7245f72842..46b43d59d9 100644 --- a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala +++ b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala @@ -26,7 +26,6 @@ import scala.jdk.CollectionConverters._ import scala.util.Random import org.apache.hadoop.fs.Path -import org.apache.spark.SparkConf import org.apache.spark.sql.{CometTestBase, DataFrame, Row, SaveMode} import org.apache.spark.sql.catalyst.expressions.Cast import org.apache.spark.sql.catalyst.parser.ParseException @@ -43,11 +42,6 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { import testImplicits._ - // Casts in this suite predominantly test non-ANSI semantics (silent overflow/null on - // invalid input); tests that target ANSI behavior opt in explicitly via withSQLConf. - override protected def sparkConf: SparkConf = - super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false") - /** Create a data generator using a fixed seed so that tests are reproducible */ private val gen = DataGenerator.DEFAULT diff --git a/spark/src/test/scala/org/apache/comet/CometFuzzMathSuite.scala b/spark/src/test/scala/org/apache/comet/CometFuzzMathSuite.scala index 50a4425f97..2848bd23d9 100644 --- a/spark/src/test/scala/org/apache/comet/CometFuzzMathSuite.scala +++ b/spark/src/test/scala/org/apache/comet/CometFuzzMathSuite.scala @@ -19,18 +19,10 @@ package org.apache.comet -import org.apache.spark.SparkConf -import org.apache.spark.sql.internal.SQLConf import org.apache.spark.sql.types.{DecimalType, IntegerType, LongType} class CometFuzzMathSuite extends CometFuzzTestBase { - // The integer-math fuzz tests intentionally cover overflowing inputs; under Spark 4's - // default ANSI mode those would throw rather than produce a result for both Spark and - // Comet to compare against. Pin ANSI off so the parity comparison can run. - override protected def sparkConf: SparkConf = - super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false") - for (op <- Seq("+", "-", "*", "/", "div")) { test(s"integer math: $op") { val df = spark.read.parquet(filename) @@ -63,5 +55,4 @@ class CometFuzzMathSuite extends CometFuzzTestBase { checkSparkAnswerAndOperator(sql) } } - }