diff --git a/docs/BUILD.bazel b/docs/BUILD.bazel index dd304c410a..baa1a1e3db 100644 --- a/docs/BUILD.bazel +++ b/docs/BUILD.bazel @@ -128,6 +128,7 @@ sphinx_stardocs( "//python/api:rule_builders", "//python/cc:py_cc_toolchain", "//python/cc:py_cc_toolchain_info", + "//python/cc:py_extension", "//python/entry_points:py_console_script_binary", "//python/extensions:config", "//python/extensions:python", diff --git a/python/cc/py_extension.bzl b/python/cc/py_extension.bzl index 2d5570b546..d81877a702 100644 --- a/python/cc/py_extension.bzl +++ b/python/cc/py_extension.bzl @@ -10,6 +10,9 @@ for information on writing C extension modules. :::{include} /_includes/experimental_api.md ::: + +:::{versionadded} VERSION_NEXT_FEATURE +::: """ load( diff --git a/python/private/cc/BUILD.bazel b/python/private/cc/BUILD.bazel index a89c47c58f..087d406932 100644 --- a/python/private/cc/BUILD.bazel +++ b/python/private/cc/BUILD.bazel @@ -43,6 +43,7 @@ bzl_library( srcs = ["py_extension_macro.bzl"], deps = [ ":py_extension_rule", + "//python/private:common_labels", "//python/private:util", "@rules_cc//cc:core_rules", ], @@ -55,11 +56,11 @@ bzl_library( "//python/private:attr_builders", "//python/private:attributes", "//python/private:builders", + "//python/private:common", "//python/private:py_info", "//python/private:reexports", "//python/private:rule_builders", "//python/private:toolchain_types", "@bazel_skylib//lib:dicts", - "@rules_cc//cc/common", ], ) diff --git a/python/private/cc/py_extension_macro.bzl b/python/private/cc/py_extension_macro.bzl index 7845a09ea2..f8b767074d 100644 --- a/python/private/cc/py_extension_macro.bzl +++ b/python/private/cc/py_extension_macro.bzl @@ -53,6 +53,9 @@ def py_extension( - `module_name`: Pass `module_name = "custom_name"` to override the base module filename. + :::{versionadded} VERSION_NEXT_FEATURE + ::: + Args: name: {type}`str` Target name. srcs: {type}`list[Label | str] | None` C/C++ source files to compile diff --git a/python/private/cc/py_extension_rule.bzl b/python/private/cc/py_extension_rule.bzl index 1c5ee11a06..d0fda25975 100644 --- a/python/private/cc/py_extension_rule.bzl +++ b/python/private/cc/py_extension_rule.bzl @@ -5,7 +5,6 @@ """ load("@bazel_skylib//lib:dicts.bzl", "dicts") -load("@rules_cc//cc/common:cc_shared_library_info.bzl", "CcSharedLibraryInfo") load("//python/private:attr_builders.bzl", "attrb") load("//python/private:attributes.bzl", "COMMON_ATTRS", "IMPORTS_ATTRS", "WINDOWS_CONSTRAINTS_ATTRS") load("//python/private:builders.bzl", "builders") @@ -78,7 +77,6 @@ PY_EXTENSION_WRAPPER_ATTRS = dicts.add( ), "src": lambda: attrb.Label( mandatory = True, - providers = [CcSharedLibraryInfo], doc = "The cc_shared_library target to wrap.", ), }, diff --git a/tests/BUILD.bazel b/tests/BUILD.bazel index e7dbef65d8..927fc30566 100644 --- a/tests/BUILD.bazel +++ b/tests/BUILD.bazel @@ -22,6 +22,7 @@ build_test( "//python:py_test_bzl", "//python/cc:py_cc_toolchain_bzl", "//python/cc:py_cc_toolchain_info_bzl", + "//python/cc:py_extension", "//python/entry_points:py_console_script_binary_bzl", ], )