From 061bea7f49f73b8c08d07b9f9a81b4387f5e8169 Mon Sep 17 00:00:00 2001
From: zgjimhaziri <z.haziri@celonis.com>
Date: Wed, 1 Jul 2026 18:02:52 +0200
Subject: [PATCH] Fix test failures from testing refactor fallout

The recent testing refactors moved the suite toward real files in temp
directories and asserting on real output instead of filesystem mocks. A PR
merged afterwards added a config-validate test written against the old
mock-based approach, referencing an undefined mockWriteFileSync that broke
compilation of the whole spec and turned main red.

Wire that test up via jest.spyOn(fs, "writeFileSync"), and harden the
FileService spec whose fixed-name temp dirs leaked between runs (EEXIST on
re-runs) so the suite is idempotent.

Includes-AI-Code: true
Co-authored-by: Cursor <cursoragent@cursor.com>
---
 .../config-validate.spec.ts                   |  3 +++
 tests/core/utils/file.service.spec.ts         | 21 ++++++-------------
 2 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/tests/commands/configuration-management/config-validate.spec.ts b/tests/commands/configuration-management/config-validate.spec.ts
index 7e5b3756..a98e87c5 100644
--- a/tests/commands/configuration-management/config-validate.spec.ts
+++ b/tests/commands/configuration-management/config-validate.spec.ts
@@ -7,6 +7,7 @@ import { testContext } from "../../utls/test-context";
 import { loggingTestTransport } from "../../jest.setup";
 import { SchemaValidationResponse } from "../../../src/commands/configuration-management/interfaces/package-validation.interfaces";
 import { getJsonFromFile } from "../../utls/fs-utils";
+import * as fs from "fs";
 
 describe("Config validate", () => {
 
@@ -170,6 +171,8 @@ describe("Config validate", () => {
 
         mockAxiosPost(VALIDATE_URL, response);
 
+        const mockWriteFileSync = jest.spyOn(fs, "writeFileSync");
+
         await new PackageValidationService(testContext).validatePackage("my-package", ["DATA_PIPELINES"], null, true);
 
         expect(mockWriteFileSync).toHaveBeenCalledWith(
diff --git a/tests/core/utils/file.service.spec.ts b/tests/core/utils/file.service.spec.ts
index ec5c492b..dcd71be6 100644
--- a/tests/core/utils/file.service.spec.ts
+++ b/tests/core/utils/file.service.spec.ts
@@ -12,27 +12,18 @@ describe("FileService", () => {
     const symLinkSourceTempDir = path.join(os.tmpdir(), "file-service-symlink-source");
 
     beforeAll(() => {
-        fileService = new FileService();
-
-        if (!fs.existsSync(tempDir)) {
-            fs.mkdirSync(tempDir, { recursive: true, mode: 0o700 });
-        }
+        rmTempDir(tempDir);
+        rmTempDir(symLinkSourceTempDir);
 
-        if (!fs.existsSync(symLinkSourceTempDir)) {
-            fs.mkdirSync(symLinkSourceTempDir, { recursive: true, mode: 0o700 });
-        }
+        fs.mkdirSync(tempDir, { recursive: true, mode: 0o700 });
+        fs.mkdirSync(symLinkSourceTempDir, { recursive: true, mode: 0o700 });
 
         fileService = new FileService();
     });
 
     afterAll(() => {
-        if (fs.existsSync(tempDir)) {
-            rmTempDir(tempDir);
-        }
-
-        if (fs.existsSync(symLinkSourceTempDir)) {
-            rmTempDir(tempDir);
-        }
+        rmTempDir(tempDir);
+        rmTempDir(symLinkSourceTempDir);
     });
 
     describe("zipDirectoryInBatchExportFormat", () => {