Skip to content

Couple of points I noticed. #6

Description

@elextr

Couple of points I noticed, wasn't by any means a real review.

  1. some of the keybindings clash with standard ones, ++e and t at least, didn't check all the rest.
  2. in zen_controller_init_python() the variable resident_pylib is static so its only ever initialised to NULL once, not sure if thats part of your commented intermittent crash on subsequent calls
  3. even if the python lib isn't found you fall through to try to initialise anyway, that would probably be a crash.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions