Skip to content

Bug Introduced in 3.3.2 - Props being removed #1997

Description

@Jake-Nolder

In the PR #1970.

In src/Player.tsx the line 77 of code is incorrect and is removing the props that are ment to be allowed though.

The problematic line of code removes the allowed props onReady and onStart and allows any random props instead.
if (key.startsWith('on') && !reactPlayerEventHandlers.includes(key)) {

It should be the inverse.
if (key.startsWith('on') && reactPlayerEventHandlers.includes(key)) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions