fix(hub-ui): address icon recovery review feedback

Author: dvcolomban

packages/hub-ui/src/client/components/icons/IconifyIcon.vue

@@ -49,6 +49,7 @@ watchEffect(async (onCleanup) => {
   </svg>
   <div
     v-else-if="iconifyParsed"
+    aria-hidden="true"
     v-html="iconifyLoaded"
   />
   <img

packages/hub-ui/src/client/utils/iconify.ts

@@ -28,10 +28,10 @@ export async function getIconifySvg(collection: string, icon: string) {
     if (!response.ok)
       throw new Error(`Iconify request failed: ${response.status}`)
     const svg = purify.sanitize(await response.text())
-    const document = new DOMParser().parseFromString(svg, 'image/svg+xml')
-    if (document.documentElement.localName !== 'svg'
-      || document.querySelector('parsererror')
-      || !document.querySelector('path, circle, ellipse, rect, line, polyline, polygon, text, use, image')) {
+    const svgDocument = new DOMParser().parseFromString(svg, 'image/svg+xml')
+    if (svgDocument.documentElement.localName !== 'svg'
+      || svgDocument.querySelector('parsererror')
+      || !svgDocument.querySelector('path, circle, ellipse, rect, line, polyline, polygon, text, use, image')) {
       throw new Error('Iconify returned an invalid SVG')
     }
     return svg