From 9cbdc695b04829efa0cbddf3f18d02faf817fc36 Mon Sep 17 00:00:00 2001 From: abdessalem Date: Sat, 19 Sep 2026 16:44:31 +0100 Subject: [PATCH] [Material_ui] Make `locales` constants in `time_picker_test.dart` --- .../change_2026_09_19_1789832369330.yaml | 3 + .../test/l10n/time_picker_test.dart | 84 +++++++++---------- 2 files changed, 45 insertions(+), 42 deletions(-) create mode 100644 packages/material_ui/pending_changelogs/change_2026_09_19_1789832369330.yaml diff --git a/packages/material_ui/pending_changelogs/change_2026_09_19_1789832369330.yaml b/packages/material_ui/pending_changelogs/change_2026_09_19_1789832369330.yaml new file mode 100644 index 000000000000..6644570e0867 --- /dev/null +++ b/packages/material_ui/pending_changelogs/change_2026_09_19_1789832369330.yaml @@ -0,0 +1,3 @@ +changelog: | + - update timePicker i10n tests to use constant locales +version: patch diff --git a/packages/material_ui/test/l10n/time_picker_test.dart b/packages/material_ui/test/l10n/time_picker_test.dart index c23f10a0e357..a7e26d5da7e9 100644 --- a/packages/material_ui/test/l10n/time_picker_test.dart +++ b/packages/material_ui/test/l10n/time_picker_test.dart @@ -36,13 +36,13 @@ void main() { ); // TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them - final locales = [ - const Locale('en', 'US'), //'h:mm a' - const Locale('en', 'GB'), //'HH:mm' - const Locale('es', 'ES'), //'H:mm' - const Locale('fr', 'CA'), //'HH \'h\' mm' - const Locale('zh', 'ZH'), //'ah:mm' - const Locale('fa', 'IR'), //'H:mm' but RTL + const locales = [ + Locale('en', 'US'), //'h:mm a' + Locale('en', 'GB'), //'HH:mm' + Locale('es', 'ES'), //'H:mm' + Locale('fr', 'CA'), //'HH \'h\' mm' + Locale('zh', 'ZH'), //'ah:mm' + Locale('fa', 'IR'), //'H:mm' but RTL ]; for (final locale in locales) { @@ -121,13 +121,13 @@ void main() { ); // TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them - final locales = [ - const Locale('en', 'US'), //'h:mm a' - const Locale('en', 'GB'), //'HH:mm' - const Locale('es', 'ES'), //'H:mm' - const Locale('fr', 'CA'), //'HH \'h\' mm' - const Locale('zh', 'ZH'), //'ah:mm' - const Locale('fa', 'IR'), //'H:mm' but RTL + const locales = [ + Locale('en', 'US'), //'h:mm a' + Locale('en', 'GB'), //'HH:mm' + Locale('es', 'ES'), //'H:mm' + Locale('fr', 'CA'), //'HH \'h\' mm' + Locale('zh', 'ZH'), //'ah:mm' + Locale('fa', 'IR'), //'H:mm' but RTL ]; for (final locale in locales) { @@ -201,13 +201,13 @@ void main() { ); // TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them - final locales = [ - const Locale('en', 'US'), //'h:mm a' - const Locale('en', 'GB'), //'HH:mm' - const Locale('es', 'ES'), //'H:mm' - const Locale('fr', 'CA'), //'HH \'h\' mm' - const Locale('zh', 'ZH'), //'ah:mm' - const Locale('fa', 'IR'), //'H:mm' but RTL + const locales = [ + Locale('en', 'US'), //'h:mm a' + Locale('en', 'GB'), //'HH:mm' + Locale('es', 'ES'), //'H:mm' + Locale('fr', 'CA'), //'HH \'h\' mm' + Locale('zh', 'ZH'), //'ah:mm' + Locale('fa', 'IR'), //'H:mm' but RTL ]; for (final locale in locales) { @@ -291,13 +291,13 @@ void main() { ); // TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them - final locales = [ - const Locale('en', 'US'), //'h:mm a' - const Locale('en', 'GB'), //'HH:mm' - const Locale('es', 'ES'), //'H:mm' - const Locale('fr', 'CA'), //'HH \'h\' mm' - const Locale('zh', 'ZH'), //'ah:mm' - const Locale('fa', 'IR'), //'H:mm' but RTL + const locales = [ + Locale('en', 'US'), //'h:mm a' + Locale('en', 'GB'), //'HH:mm' + Locale('es', 'ES'), //'H:mm' + Locale('fr', 'CA'), //'HH \'h\' mm' + Locale('zh', 'ZH'), //'ah:mm' + Locale('fa', 'IR'), //'H:mm' but RTL ]; for (final locale in locales) { @@ -371,13 +371,13 @@ void main() { .first; // TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them - final locales = [ - const Locale('en', 'US'), //'h:mm a' - const Locale('en', 'GB'), //'HH:mm' - const Locale('es', 'ES'), //'H:mm' - const Locale('fr', 'CA'), //'HH \'h\' mm' - const Locale('zh', 'ZH'), //'ah:mm' - const Locale('fa', 'IR'), //'H:mm' but RTL + const locales = [ + Locale('en', 'US'), //'h:mm a' + Locale('en', 'GB'), //'HH:mm' + Locale('es', 'ES'), //'H:mm' + Locale('fr', 'CA'), //'HH \'h\' mm' + Locale('zh', 'ZH'), //'ah:mm' + Locale('fa', 'IR'), //'H:mm' but RTL ]; for (final locale in locales) { @@ -456,13 +456,13 @@ void main() { .first; // TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them - final locales = [ - const Locale('en', 'US'), //'h:mm a' - const Locale('en', 'GB'), //'HH:mm' - const Locale('es', 'ES'), //'H:mm' - const Locale('fr', 'CA'), //'HH \'h\' mm' - const Locale('zh', 'ZH'), //'ah:mm' - const Locale('fa', 'IR'), //'H:mm' but RTL + const locales = [ + Locale('en', 'US'), //'h:mm a' + Locale('en', 'GB'), //'HH:mm' + Locale('es', 'ES'), //'H:mm' + Locale('fr', 'CA'), //'HH \'h\' mm' + Locale('zh', 'ZH'), //'ah:mm' + Locale('fa', 'IR'), //'H:mm' but RTL ]; for (final locale in locales) {