Use Windows-safe cleanup for object-directory test

The replacement Python 3.7 Windows run confirmed that every test assertion passes, but tempfile.TemporaryDirectory cannot remove the read-only loose object produced by Git and reports WinError 5.

Use the test suite's existing with_rw_directory helper, which collects lingering references and removes read-only files correctly on Windows.

Validation: focused pytest; Ruff check and format; mypy; compileall; git diff --check.

Author: codex

test/test_repo.py

@@ -271,29 +271,29 @@ def test_repo_discovery_uses_storage_environment(self):
 
                 assert osp.samefile(Repo(git_dir).common_dir, byte_common_dir)
 
-    def test_repo_discovery_preserves_object_directory(self):
-        with tempfile.TemporaryDirectory() as tdir:
-            git_dir = Path(tdir) / "git"
-            payload = b"custom object database"
-            payload_file = Path(tdir) / "payload"
-            payload_file.write_bytes(payload)
-
-            source_repo = Repo.init(git_dir, bare=True)
-            blob_hexsha = source_repo.git.hash_object("-w", payload_file)
-            source_repo.close()
-            object_dir = Path(tdir) / "objects"
-            (git_dir / "objects").rename(object_dir)
-
-            with cwd(tdir), mock.patch.dict(os.environ, {"GIT_DIR": "git", "GIT_OBJECT_DIRECTORY": "objects"}):
-                repo = Repo(odbt=GitDB)
-
-            with repo:
-                assert osp.samefile(repo.odb.root_path(), object_dir)
-                assert repo.odb.has_object(bytes.fromhex(blob_hexsha))
-                assert repo.git.cat_file("blob", blob_hexsha) == payload.decode()
-                repo.alternates = ["other/location"]
-                assert repo.alternates == ["other/location"]
-                assert (object_dir / "info" / "alternates").is_file()
+    @with_rw_directory
+    def test_repo_discovery_preserves_object_directory(self, tdir):
+        git_dir = Path(tdir) / "git"
+        payload = b"custom object database"
+        payload_file = Path(tdir) / "payload"
+        payload_file.write_bytes(payload)
+
+        source_repo = Repo.init(git_dir, bare=True)
+        blob_hexsha = source_repo.git.hash_object("-w", payload_file)
+        source_repo.close()
+        object_dir = Path(tdir) / "objects"
+        (git_dir / "objects").rename(object_dir)
+
+        with cwd(tdir), mock.patch.dict(os.environ, {"GIT_DIR": "git", "GIT_OBJECT_DIRECTORY": "objects"}):
+            repo = Repo(odbt=GitDB)
+
+        with repo:
+            assert osp.samefile(repo.odb.root_path(), object_dir)
+            assert repo.odb.has_object(bytes.fromhex(blob_hexsha))
+            assert repo.git.cat_file("blob", blob_hexsha) == payload.decode()
+            repo.alternates = ["other/location"]
+            assert repo.alternates == ["other/location"]
+            assert (object_dir / "info" / "alternates").is_file()
 
     @with_rw_repo("0.3.2.1")
     def test_repo_creation_from_different_paths(self, rw_repo):