From 14bc3745d09faa6578f964064b454c6e469af863 Mon Sep 17 00:00:00 2001
From: Andrew Arnott <andrew.arnott@microsoft.com>
Date: Wed, 2 Sep 2026 08:20:35 -0600
Subject: [PATCH] Fix incorrect ValueTask doc comment on VSTHRD114 analyzer

Audited all analyzers for issue #414 (ValueTask support). Found:
- VSTHRD111 (ConfigureAwait): already handles ValueTask explicitly.
- VSTHRD011, VSTHRD109, VSTHRD200: use HasAsyncCompatibleReturnType/IsAsyncCompatibleReturnType, which already recognize ValueTask via its AsyncMethodBuilderAttribute.
- VSTHRD110, VSTHRD200 Remove-suffix check: use AwaitableTypeTester, which discovers any type with a GetAwaiter method, including ValueTask.
- VSTHRD012, VSTHRD108, VSTHRD001, VSTHRD004, VSTHRD100, VSTHRD106, VSTHRD116/117: not Task-type-specific; no gap.
- VSTHRD114 (avoid returning null Task): its doc comment incorrectly claimed ValueTask support, but ValueTask/ValueTask<T> are value types so \
eturn null;\ is a compile error (CS0037) and can never reach this analyzer. Corrected the doc comment to explain this instead of implying non-existent support.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---
 .../AbstractVSTHRD114AvoidReturningNullTaskAnalyzer.cs     | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/Microsoft.VisualStudio.Threading.Analyzers/AbstractVSTHRD114AvoidReturningNullTaskAnalyzer.cs b/src/Microsoft.VisualStudio.Threading.Analyzers/AbstractVSTHRD114AvoidReturningNullTaskAnalyzer.cs
index b677d1bfe..9e81c7c41 100644
--- a/src/Microsoft.VisualStudio.Threading.Analyzers/AbstractVSTHRD114AvoidReturningNullTaskAnalyzer.cs
+++ b/src/Microsoft.VisualStudio.Threading.Analyzers/AbstractVSTHRD114AvoidReturningNullTaskAnalyzer.cs
@@ -10,9 +10,12 @@
 namespace Microsoft.VisualStudio.Threading.Analyzers;
 
 /// <summary>
-/// Finds await expressions on <see cref="Task"/> that do not use <see cref="Task.ConfigureAwait(bool)"/>.
-/// Also works on <see cref="ValueTask"/>.
+/// Finds methods that return <see langword="null"/> in place of a <see cref="Task"/> or <see cref="Task{TResult}"/>.
 /// </summary>
+/// <remarks>
+/// <see cref="ValueTask"/> and <see cref="ValueTask{TResult}"/> are value types, so <see langword="null"/> cannot be
+/// returned in their place and the compiler already prevents this pattern for them.
+/// </remarks>
 public abstract class AbstractVSTHRD114AvoidReturningNullTaskAnalyzer : DiagnosticAnalyzer
 {
     public const string Id = "VSTHRD114";