Skip to content

Choose color for bottom sheet handle #117

Description

@barry-observation

Context
A bottom sheet contains a "handle" that shows you can drag the sheet to become bigger or smaller. We have been inconsistent in the use of the color of this handle.

In react-native-components, in bottomSheet.ts, we use theme.color.icon.system.subtle. You could say this is the wrong type of color because the handle is not an icon? But it otherwise unclear whether this is a background color, a border color or something else.

In Observation, in BottomSheetStyles, we use theme.color.grey800.

Requirements

  • We need to resolve this inconsistency by choosing 1 color to use everywhere
  • We can discuss what type of color this is, so we can give it the correct semantic name
  • Once done, we need to apply the new color in
    • the react-native-components
    • ObsIdentify (should be a matter of updating react-native-components)
    • Observation (update react-native-components and the deprecated bottomSheetStyles)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions