gh-153569: remove unused source views and unrelated test cleanup

Author: pablogsal

Lib/test/support/os_helper.py

@@ -433,7 +433,7 @@ def _rmtree_inner(path):
                           % (fullname, exc),
                           file=sys.__stderr__)
                     mode = 0
-                if stat.S_ISDIR(mode) and not os.path.isjunction(fullname):
+                if stat.S_ISDIR(mode):
                     _waitfor(_rmtree_inner, fullname, waitall=True)
                     _force_run(fullname, os.rmdir, fullname)
                 else:

Modules/_testinternalcapi/tokenizer.c

@@ -51,17 +51,9 @@ test_tokenizer_source(PyObject *Py_UNUSED(module),
         goto error;
     }
 
-    Py_ssize_t view_len;
-    const char *view = _PyTok_SourceSpanView(
-        &source, _PyTok_SpanFromBounds(6, 8), &view_len);
-    if (check(view != NULL && view_len == 2 &&
-                  memcmp(view, "\xce\xb2", 2) == 0,
-              "wrong source span view") < 0 ||
-            check_system_error(
-                _PyTok_SourceSpanView(
-                    &source, _PyTok_SpanFromBounds(0, source.len + 1),
-                    &view_len) == NULL,
-                "accepted invalid source span") < 0) {
+    if (check(source.len == 9 &&
+                  memcmp(source.bytes, "alpha\n\xce\xb2\n", 10) == 0,
+              "wrong source contents") < 0) {
         goto error;
     }
 

Parser/tokenizer/source.c

@@ -134,18 +134,6 @@ _PyTok_SourceAppendLine(_PyTok_SourceText *source, const char *bytes,
     return start;
 }
 
-const char *
-_PyTok_SourceSpanView(const _PyTok_SourceText *source, _PyTok_Span span,
-                      Py_ssize_t *len)
-{
-    if (!_PyTok_SpanIsValid(span) || span.end > source->len || len == NULL) {
-        PyErr_SetString(PyExc_SystemError, "invalid tokenizer source span");
-        return NULL;
-    }
-    *len = span.end - span.start;
-    return source->bytes == NULL ? "" : source->bytes + span.start;
-}
-
 int
 _PyTok_SourceLineIsImplicit(const _PyTok_SourceText *source, int lineno)
 {

Parser/tokenizer/source.h

@@ -37,9 +37,6 @@ PyAPI_FUNC(void) _PyTok_SourceClear(_PyTok_SourceText *);
 PyAPI_FUNC(_PyTok_Off) _PyTok_SourceAppendLine(
     _PyTok_SourceText *source, const char *bytes, Py_ssize_t len,
     int implicit_newline);
-/* The returned view is invalidated by SourceAppendLine and SourceClear. */
-PyAPI_FUNC(const char *) _PyTok_SourceSpanView(
-    const _PyTok_SourceText *, _PyTok_Span, Py_ssize_t *);
 /* Return false for invalid line numbers and the virtual EOF line. */
 PyAPI_FUNC(int) _PyTok_SourceLineIsImplicit(
     const _PyTok_SourceText *, int);