You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All three touch the shared forest base and tree split logic. One design pass avoids three colliding PRs:
Sample weights must flow through bootstrap sampling and split-criterion weighting.
Forest-level importances should reuse DecisionTreeClassifier::compute_feature_importances (src/tree/decision_tree_classifier.rs) and add the missing regressor-tree variant.
Tracking issue for ensemble work that shares one design surface (
base_forest_*, tree internals). Do not start code before an RFC is agreed here.Member issues
Why grouped
All three touch the shared forest base and tree split logic. One design pass avoids three colliding PRs:
DecisionTreeClassifier::compute_feature_importances(src/tree/decision_tree_classifier.rs) and add the missing regressor-tree variant.Constraints (repo conventions)
iterator(...)/ view traits.numbers/traits only.Default::default()(see Serde JSON defaults don't match Default::default() #175 lessons).mod tests {}per module.RFC requirements
Post a short RFC comment before any PR: API sketch, trait bounds, serde story, no_std impact for v0.7.
Acceptance criteria