From 73ee79324ff0a56ca71f5ecb9ea00ee70721b56d Mon Sep 17 00:00:00 2001 From: GokceGK Date: Tue, 8 Sep 2026 16:07:06 +0200 Subject: [PATCH 1/3] feat(valkey): add Key Value Store to valkey descriptions relates to STACKITTPR-845 --- docs/stackit.md | 2 +- docs/stackit_valkey.md | 10 ++++----- docs/stackit_valkey_credentials.md | 14 ++++++------ docs/stackit_valkey_credentials_create.md | 10 ++++----- docs/stackit_valkey_credentials_delete.md | 8 +++---- docs/stackit_valkey_credentials_describe.md | 10 ++++----- docs/stackit_valkey_credentials_list.md | 12 +++++----- docs/stackit_valkey_instance.md | 16 +++++++------- docs/stackit_valkey_instance_create.md | 14 ++++++------ docs/stackit_valkey_instance_delete.md | 8 +++---- docs/stackit_valkey_instance_describe.md | 10 ++++----- docs/stackit_valkey_instance_list.md | 12 +++++----- docs/stackit_valkey_instance_update.md | 14 ++++++------ docs/stackit_valkey_plans.md | 12 +++++----- internal/cmd/redis/redis.go | 2 +- .../cmd/valkey/credentials/create/create.go | 12 +++++----- .../cmd/valkey/credentials/credentials.go | 4 ++-- .../cmd/valkey/credentials/delete/delete.go | 8 +++---- .../valkey/credentials/describe/describe.go | 10 ++++----- internal/cmd/valkey/credentials/list/list.go | 12 +++++----- internal/cmd/valkey/instance/create/create.go | 22 +++++++++---------- internal/cmd/valkey/instance/delete/delete.go | 10 ++++----- .../cmd/valkey/instance/describe/describe.go | 10 ++++----- internal/cmd/valkey/instance/instance.go | 4 ++-- internal/cmd/valkey/instance/list/list.go | 12 +++++----- internal/cmd/valkey/instance/update/update.go | 20 ++++++++--------- internal/cmd/valkey/plans/plans.go | 12 +++++----- internal/cmd/valkey/valkey.go | 4 ++-- internal/pkg/services/valkey/utils/utils.go | 4 ++-- 29 files changed, 149 insertions(+), 149 deletions(-) diff --git a/docs/stackit.md b/docs/stackit.md index 5f6b1107a..81c7aef64 100644 --- a/docs/stackit.md +++ b/docs/stackit.md @@ -59,6 +59,6 @@ stackit [flags] * [stackit service-account](./stackit_service-account.md) - Provides functionality for service accounts * [stackit ske](./stackit_ske.md) - Provides functionality for SKE * [stackit sqlserverflex](./stackit_sqlserverflex.md) - Provides functionality for SQLServer Flex -* [stackit valkey](./stackit_valkey.md) - Provides functionality for Valkey +* [stackit valkey](./stackit_valkey.md) - Provides functionality for Key Value Store (valkey) * [stackit volume](./stackit_volume.md) - Provides functionality for volumes diff --git a/docs/stackit_valkey.md b/docs/stackit_valkey.md index 77511dd42..2d3f77130 100644 --- a/docs/stackit_valkey.md +++ b/docs/stackit_valkey.md @@ -1,10 +1,10 @@ ## stackit valkey -Provides functionality for Valkey +Provides functionality for Key Value Store (valkey) ### Synopsis -Provides functionality for Valkey. +Provides functionality for Key Value Store (valkey). ``` stackit valkey [flags] @@ -30,7 +30,7 @@ stackit valkey [flags] ### SEE ALSO * [stackit](./stackit.md) - Manage STACKIT resources using the command line -* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Valkey credentials -* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Valkey instances -* [stackit valkey plans](./stackit_valkey_plans.md) - Lists all Valkey service plans +* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Key Value Store (valkey) credentials +* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Key Value Store (valkey) instances +* [stackit valkey plans](./stackit_valkey_plans.md) - Lists all Key Value Store (valkey) service plans diff --git a/docs/stackit_valkey_credentials.md b/docs/stackit_valkey_credentials.md index ed791aeb7..955bd2f57 100644 --- a/docs/stackit_valkey_credentials.md +++ b/docs/stackit_valkey_credentials.md @@ -1,10 +1,10 @@ ## stackit valkey credentials -Provides functionality for Valkey credentials +Provides functionality for Key Value Store (valkey) credentials ### Synopsis -Provides functionality for Valkey credentials. +Provides functionality for Key Value Store (valkey) credentials. ``` stackit valkey credentials [flags] @@ -29,9 +29,9 @@ stackit valkey credentials [flags] ### SEE ALSO -* [stackit valkey](./stackit_valkey.md) - Provides functionality for Valkey -* [stackit valkey credentials create](./stackit_valkey_credentials_create.md) - Creates credentials for a Valkey instance -* [stackit valkey credentials delete](./stackit_valkey_credentials_delete.md) - Deletes credentials of a Valkey instance -* [stackit valkey credentials describe](./stackit_valkey_credentials_describe.md) - Shows details of credentials of a Valkey instance -* [stackit valkey credentials list](./stackit_valkey_credentials_list.md) - Lists all credentials' IDs for a Valkey instance +* [stackit valkey](./stackit_valkey.md) - Provides functionality for Key Value Store (valkey) +* [stackit valkey credentials create](./stackit_valkey_credentials_create.md) - Creates credentials for a Key Value Store (valkey) instance +* [stackit valkey credentials delete](./stackit_valkey_credentials_delete.md) - Deletes credentials of a Key Value Store (valkey) instance +* [stackit valkey credentials describe](./stackit_valkey_credentials_describe.md) - Shows details of credentials of a Key Value Store (valkey) instance +* [stackit valkey credentials list](./stackit_valkey_credentials_list.md) - Lists all credentials' IDs for a Key Value Store (valkey) instance diff --git a/docs/stackit_valkey_credentials_create.md b/docs/stackit_valkey_credentials_create.md index cc1c123bf..c610a7b20 100644 --- a/docs/stackit_valkey_credentials_create.md +++ b/docs/stackit_valkey_credentials_create.md @@ -1,10 +1,10 @@ ## stackit valkey credentials create -Creates credentials for a Valkey instance +Creates credentials for a Key Value Store (valkey) instance ### Synopsis -Creates credentials (username and password) for a Valkey instance. +Creates credentials (username and password) for a Key Value Store (valkey) instance. ``` stackit valkey credentials create [flags] @@ -13,10 +13,10 @@ stackit valkey credentials create [flags] ### Examples ``` - Create credentials for a Valkey instance with ID "xxx" + Create credentials for a Key Value Store (valkey) instance with ID "xxx" $ stackit valkey credentials create --instance-id xxx - Create credentials for a Valkey instance and show the password in the output + Create credentials for a Key Value Store (valkey) instance and show the password in the output $ stackit valkey credentials create --instance-id xxx --show-password ``` @@ -41,5 +41,5 @@ stackit valkey credentials create [flags] ### SEE ALSO -* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Valkey credentials +* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Key Value Store (valkey) credentials diff --git a/docs/stackit_valkey_credentials_delete.md b/docs/stackit_valkey_credentials_delete.md index 73a920b04..e4bac86cb 100644 --- a/docs/stackit_valkey_credentials_delete.md +++ b/docs/stackit_valkey_credentials_delete.md @@ -1,10 +1,10 @@ ## stackit valkey credentials delete -Deletes credentials of a Valkey instance +Deletes credentials of a Key Value Store (valkey) instance ### Synopsis -Deletes credentials of a Valkey instance. +Deletes credentials of a Key Value Store (valkey) instance. ``` stackit valkey credentials delete CREDENTIALS_ID [flags] @@ -13,7 +13,7 @@ stackit valkey credentials delete CREDENTIALS_ID [flags] ### Examples ``` - Delete credentials with ID "xxx" of a Valkey instance with ID "yyy" + Delete credentials with ID "xxx" of a Key Value Store (valkey) instance with ID "yyy" $ stackit valkey credentials delete xxx --instance-id yyy ``` @@ -37,5 +37,5 @@ stackit valkey credentials delete CREDENTIALS_ID [flags] ### SEE ALSO -* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Valkey credentials +* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Key Value Store (valkey) credentials diff --git a/docs/stackit_valkey_credentials_describe.md b/docs/stackit_valkey_credentials_describe.md index 5aff7effa..2ed16e577 100644 --- a/docs/stackit_valkey_credentials_describe.md +++ b/docs/stackit_valkey_credentials_describe.md @@ -1,10 +1,10 @@ ## stackit valkey credentials describe -Shows details of credentials of a Valkey instance +Shows details of credentials of a Key Value Store (valkey) instance ### Synopsis -Shows details of credentials of a Valkey instance. The password will be shown in plain text in the output. +Shows details of credentials of a Key Value Store (valkey) instance. The password will be shown in plain text in the output. ``` stackit valkey credentials describe CREDENTIALS_ID [flags] @@ -13,10 +13,10 @@ stackit valkey credentials describe CREDENTIALS_ID [flags] ### Examples ``` - Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy" + Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy" $ stackit valkey credentials describe xxx --instance-id yyy - Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy" in JSON format + Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy" in JSON format $ stackit valkey credentials describe xxx --instance-id yyy --output-format json ``` @@ -40,5 +40,5 @@ stackit valkey credentials describe CREDENTIALS_ID [flags] ### SEE ALSO -* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Valkey credentials +* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Key Value Store (valkey) credentials diff --git a/docs/stackit_valkey_credentials_list.md b/docs/stackit_valkey_credentials_list.md index a3734d69b..b95bb7304 100644 --- a/docs/stackit_valkey_credentials_list.md +++ b/docs/stackit_valkey_credentials_list.md @@ -1,10 +1,10 @@ ## stackit valkey credentials list -Lists all credentials' IDs for a Valkey instance +Lists all credentials' IDs for a Key Value Store (valkey) instance ### Synopsis -Lists all credentials' IDs for a Valkey instance. +Lists all credentials' IDs for a Key Value Store (valkey) instance. ``` stackit valkey credentials list [flags] @@ -13,13 +13,13 @@ stackit valkey credentials list [flags] ### Examples ``` - List all credentials' IDs for a Valkey instance with ID "xxx" + List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" $ stackit valkey credentials list --instance-id xxx - List all credentials' IDs for a Valkey instance with ID "xxx" in JSON format + List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" in JSON format $ stackit valkey credentials list --instance-id xxx --output-format json - List up to 10 credentials' IDs for a Valkey instance with ID "xxx" + List up to 10 credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" $ stackit valkey credentials list --instance-id xxx --limit 10 ``` @@ -44,5 +44,5 @@ stackit valkey credentials list [flags] ### SEE ALSO -* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Valkey credentials +* [stackit valkey credentials](./stackit_valkey_credentials.md) - Provides functionality for Key Value Store (valkey) credentials diff --git a/docs/stackit_valkey_instance.md b/docs/stackit_valkey_instance.md index e5ca637a4..c18f7eb13 100644 --- a/docs/stackit_valkey_instance.md +++ b/docs/stackit_valkey_instance.md @@ -1,10 +1,10 @@ ## stackit valkey instance -Provides functionality for Valkey instances +Provides functionality for Key Value Store (valkey) instances ### Synopsis -Provides functionality for Valkey instances. +Provides functionality for Key Value Store (valkey) instances. ``` stackit valkey instance [flags] @@ -29,10 +29,10 @@ stackit valkey instance [flags] ### SEE ALSO -* [stackit valkey](./stackit_valkey.md) - Provides functionality for Valkey -* [stackit valkey instance create](./stackit_valkey_instance_create.md) - Creates a Valkey instance -* [stackit valkey instance delete](./stackit_valkey_instance_delete.md) - Deletes a Valkey instance -* [stackit valkey instance describe](./stackit_valkey_instance_describe.md) - Shows details of a Valkey instance -* [stackit valkey instance list](./stackit_valkey_instance_list.md) - Lists all Valkey instances -* [stackit valkey instance update](./stackit_valkey_instance_update.md) - Updates a Valkey instance +* [stackit valkey](./stackit_valkey.md) - Provides functionality for Key Value Store (valkey) +* [stackit valkey instance create](./stackit_valkey_instance_create.md) - Creates a Key Value Store (valkey) instance +* [stackit valkey instance delete](./stackit_valkey_instance_delete.md) - Deletes a Key Value Store (valkey) instance +* [stackit valkey instance describe](./stackit_valkey_instance_describe.md) - Shows details of a Key Value Store (valkey) instance +* [stackit valkey instance list](./stackit_valkey_instance_list.md) - Lists all Key Value Store (valkey) instances +* [stackit valkey instance update](./stackit_valkey_instance_update.md) - Updates a Key Value Store (valkey) instance diff --git a/docs/stackit_valkey_instance_create.md b/docs/stackit_valkey_instance_create.md index 15a0b4430..392aedb4f 100644 --- a/docs/stackit_valkey_instance_create.md +++ b/docs/stackit_valkey_instance_create.md @@ -1,10 +1,10 @@ ## stackit valkey instance create -Creates a Valkey instance +Creates a Key Value Store (valkey) instance ### Synopsis -Creates a Valkey instance. +Creates a Key Value Store (valkey) instance. ``` stackit valkey instance create [flags] @@ -13,13 +13,13 @@ stackit valkey instance create [flags] ### Examples ``` - Create a Valkey instance with name "my-instance" and specify plan by name and version + Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by name and version $ stackit valkey instance create --name my-instance --plan-name stackit-keyvalue-1.2.10-replica --version 8 - Create a Valkey instance with name "my-instance" and specify plan by ID + Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by ID $ stackit valkey instance create --name my-instance --plan-id xxx - Create a Valkey instance with name "my-instance" and specify IP range which is allowed to access it + Create a Key Value Store (valkey) instance with name "my-instance" and specify IP range which is allowed to access it $ stackit valkey instance create --name my-instance --plan-id xxx --acl 1.2.3.0/24 ``` @@ -39,7 +39,7 @@ stackit valkey instance create [flags] --plan-name string Plan name --repl-backlog-size string Replication backlog size (e.g. "1mb") --syslog strings Syslog - --version string Instance Valkey version + --version string Instance Key Value Store (valkey) version ``` ### Options inherited from parent commands @@ -55,5 +55,5 @@ stackit valkey instance create [flags] ### SEE ALSO -* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Valkey instances +* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Key Value Store (valkey) instances diff --git a/docs/stackit_valkey_instance_delete.md b/docs/stackit_valkey_instance_delete.md index 2390993ee..603680bf9 100644 --- a/docs/stackit_valkey_instance_delete.md +++ b/docs/stackit_valkey_instance_delete.md @@ -1,10 +1,10 @@ ## stackit valkey instance delete -Deletes a Valkey instance +Deletes a Key Value Store (valkey) instance ### Synopsis -Deletes a Valkey instance. +Deletes a Key Value Store (valkey) instance. ``` stackit valkey instance delete INSTANCE_ID [flags] @@ -13,7 +13,7 @@ stackit valkey instance delete INSTANCE_ID [flags] ### Examples ``` - Delete a Valkey instance with ID "xxx" + Delete a Key Value Store (valkey) instance with ID "xxx" $ stackit valkey instance delete xxx ``` @@ -36,5 +36,5 @@ stackit valkey instance delete INSTANCE_ID [flags] ### SEE ALSO -* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Valkey instances +* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Key Value Store (valkey) instances diff --git a/docs/stackit_valkey_instance_describe.md b/docs/stackit_valkey_instance_describe.md index 892aaa292..ff233cbf5 100644 --- a/docs/stackit_valkey_instance_describe.md +++ b/docs/stackit_valkey_instance_describe.md @@ -1,10 +1,10 @@ ## stackit valkey instance describe -Shows details of a Valkey instance +Shows details of a Key Value Store (valkey) instance ### Synopsis -Shows details of a Valkey instance. +Shows details of a Key Value Store (valkey) instance. ``` stackit valkey instance describe INSTANCE_ID [flags] @@ -13,10 +13,10 @@ stackit valkey instance describe INSTANCE_ID [flags] ### Examples ``` - Get details of a Valkey instance with ID "xxx" + Get details of a Key Value Store (valkey) instance with ID "xxx" $ stackit valkey instance describe xxx - Get details of a Valkey instance with ID "xxx" in JSON format + Get details of a Key Value Store (valkey) instance with ID "xxx" in JSON format $ stackit valkey instance describe xxx --output-format json ``` @@ -39,5 +39,5 @@ stackit valkey instance describe INSTANCE_ID [flags] ### SEE ALSO -* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Valkey instances +* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Key Value Store (valkey) instances diff --git a/docs/stackit_valkey_instance_list.md b/docs/stackit_valkey_instance_list.md index aee0ba98a..25dbd81b3 100644 --- a/docs/stackit_valkey_instance_list.md +++ b/docs/stackit_valkey_instance_list.md @@ -1,10 +1,10 @@ ## stackit valkey instance list -Lists all Valkey instances +Lists all Key Value Store (valkey) instances ### Synopsis -Lists all Valkey instances. +Lists all Key Value Store (valkey) instances. ``` stackit valkey instance list [flags] @@ -13,13 +13,13 @@ stackit valkey instance list [flags] ### Examples ``` - List all Valkey instances + List all Key Value Store (valkey) instances $ stackit valkey instance list - List all Valkey instances in JSON format + List all Key Value Store (valkey) instances in JSON format $ stackit valkey instance list --output-format json - List up to 10 Valkey instances + List up to 10 Key Value Store (valkey) instances $ stackit valkey instance list --limit 10 ``` @@ -43,5 +43,5 @@ stackit valkey instance list [flags] ### SEE ALSO -* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Valkey instances +* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Key Value Store (valkey) instances diff --git a/docs/stackit_valkey_instance_update.md b/docs/stackit_valkey_instance_update.md index c380ba944..a5094222f 100644 --- a/docs/stackit_valkey_instance_update.md +++ b/docs/stackit_valkey_instance_update.md @@ -1,10 +1,10 @@ ## stackit valkey instance update -Updates a Valkey instance +Updates a Key Value Store (valkey) instance ### Synopsis -Updates a Valkey instance. +Updates a Key Value Store (valkey) instance. ``` stackit valkey instance update INSTANCE_ID [flags] @@ -13,13 +13,13 @@ stackit valkey instance update INSTANCE_ID [flags] ### Examples ``` - Update the plan of a Valkey instance with ID "xxx" by plan ID + Update the plan of a Key Value Store (valkey) instance with ID "xxx" by plan ID $ stackit valkey instance update xxx --plan-id yyy - Update the plan of a Valkey instance with ID "xxx" by name and version + Update the plan of a Key Value Store (valkey) instance with ID "xxx" by name and version $ stackit valkey instance update xxx --plan-name stackit-keyvalue-1.2.10-replica --version 8 - Update the range of IPs allowed to access a Valkey instance with ID "xxx" + Update the range of IPs allowed to access a Key Value Store (valkey) instance with ID "xxx" $ stackit valkey instance update xxx --acl 1.2.3.0/24 ``` @@ -38,7 +38,7 @@ stackit valkey instance update INSTANCE_ID [flags] --plan-name string Plan name --repl-backlog-size string Replication backlog size (e.g. "1mb") --syslog strings Syslog - --version string Instance Valkey version + --version string Instance Key Value Store (valkey) version ``` ### Options inherited from parent commands @@ -54,5 +54,5 @@ stackit valkey instance update INSTANCE_ID [flags] ### SEE ALSO -* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Valkey instances +* [stackit valkey instance](./stackit_valkey_instance.md) - Provides functionality for Key Value Store (valkey) instances diff --git a/docs/stackit_valkey_plans.md b/docs/stackit_valkey_plans.md index b3ed9dc0e..3f0e57b5b 100644 --- a/docs/stackit_valkey_plans.md +++ b/docs/stackit_valkey_plans.md @@ -1,10 +1,10 @@ ## stackit valkey plans -Lists all Valkey service plans +Lists all Key Value Store (valkey) service plans ### Synopsis -Lists all Valkey service plans. +Lists all Key Value Store (valkey) service plans. ``` stackit valkey plans [flags] @@ -13,13 +13,13 @@ stackit valkey plans [flags] ### Examples ``` - Lists all Valkey service plans + Lists all Key Value Store (valkey) service plans $ stackit valkey plans - List all Valkey service plans in JSON format + List all Key Value Store (valkey) service plans in JSON format $ stackit valkey plans --output-format json - List up to 10 Valkey service plans + List up to 10 Key Value Store (valkey) service plans $ stackit valkey plans --limit 10 ``` @@ -43,5 +43,5 @@ stackit valkey plans [flags] ### SEE ALSO -* [stackit valkey](./stackit_valkey.md) - Provides functionality for Valkey +* [stackit valkey](./stackit_valkey.md) - Provides functionality for Key Value Store (valkey) diff --git a/internal/cmd/redis/redis.go b/internal/cmd/redis/redis.go index 5e4b5d07f..190abb4b5 100644 --- a/internal/cmd/redis/redis.go +++ b/internal/cmd/redis/redis.go @@ -15,7 +15,7 @@ import ( func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "redis", - Deprecated: "\nRedis commands `stackit redis` have been deprecated and will be removed after 2027-08-31. Please use valkey (Key Value Store) commands `stackit valkey` instead.", + Deprecated: "\nRedis commands `stackit redis` have been deprecated and will be removed after 2027-08-31. Please use Key Value Store (valkey) commands `stackit valkey` instead.", Short: "Provides functionality for Redis", Long: "Provides functionality for Redis.", Args: args.NoArgs, diff --git a/internal/cmd/valkey/credentials/create/create.go b/internal/cmd/valkey/credentials/create/create.go index 679aa041b..a975e5b43 100644 --- a/internal/cmd/valkey/credentials/create/create.go +++ b/internal/cmd/valkey/credentials/create/create.go @@ -35,15 +35,15 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "create", - Short: "Creates credentials for a Valkey instance", - Long: "Creates credentials (username and password) for a Valkey instance.", + Short: "Creates credentials for a Key Value Store (valkey) instance", + Long: "Creates credentials (username and password) for a Key Value Store (valkey) instance.", Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `Create credentials for a Valkey instance with ID "xxx"`, + `Create credentials for a Key Value Store (valkey) instance with ID "xxx"`, "$ stackit valkey credentials create --instance-id xxx"), examples.NewExample( - `Create credentials for a Valkey instance and show the password in the output`, + `Create credentials for a Key Value Store (valkey) instance and show the password in the output`, "$ stackit valkey credentials create --instance-id xxx --show-password"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -75,7 +75,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) resp, err := req.Execute() if err != nil { - return fmt.Errorf("create Valkey credentials: %w", err) + return fmt.Errorf("create Key Value Store (valkey) credentials: %w", err) } credentialsId := resp.Id @@ -87,7 +87,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Valkey credentials creation: %w", err) + return fmt.Errorf("wait for Key Value Store (valkey) credentials creation: %w", err) } } diff --git a/internal/cmd/valkey/credentials/credentials.go b/internal/cmd/valkey/credentials/credentials.go index 26b776a64..c5c0fd299 100644 --- a/internal/cmd/valkey/credentials/credentials.go +++ b/internal/cmd/valkey/credentials/credentials.go @@ -15,8 +15,8 @@ import ( func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "credentials", - Short: "Provides functionality for Valkey credentials", - Long: "Provides functionality for Valkey credentials.", + Short: "Provides functionality for Key Value Store (valkey) credentials", + Long: "Provides functionality for Key Value Store (valkey) credentials.", Args: args.NoArgs, Run: utils.CmdHelp, } diff --git a/internal/cmd/valkey/credentials/delete/delete.go b/internal/cmd/valkey/credentials/delete/delete.go index bdadcbd40..226a8a73b 100644 --- a/internal/cmd/valkey/credentials/delete/delete.go +++ b/internal/cmd/valkey/credentials/delete/delete.go @@ -34,12 +34,12 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: fmt.Sprintf("delete %s", credentialsIdArg), - Short: "Deletes credentials of a Valkey instance", - Long: "Deletes credentials of a Valkey instance.", + Short: "Deletes credentials of a Key Value Store (valkey) instance", + Long: "Deletes credentials of a Key Value Store (valkey) instance.", Args: args.SingleArg(credentialsIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Delete credentials with ID "xxx" of a Valkey instance with ID "yyy"`, + `Delete credentials with ID "xxx" of a Key Value Store (valkey) instance with ID "yyy"`, "$ stackit valkey credentials delete xxx --instance-id yyy"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -77,7 +77,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) err = req.Execute() if err != nil { - return fmt.Errorf("delete Valkey credentials: %w", err) + return fmt.Errorf("delete Key Value Store (valkey) credentials: %w", err) } params.Printer.Info("Deleted credentials %s of instance %q\n", credentialsLabel, instanceLabel) diff --git a/internal/cmd/valkey/credentials/describe/describe.go b/internal/cmd/valkey/credentials/describe/describe.go index ff48d2b4b..709149d79 100644 --- a/internal/cmd/valkey/credentials/describe/describe.go +++ b/internal/cmd/valkey/credentials/describe/describe.go @@ -34,15 +34,15 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: fmt.Sprintf("describe %s", credentialsIdArg), - Short: "Shows details of credentials of a Valkey instance", - Long: "Shows details of credentials of a Valkey instance. The password will be shown in plain text in the output.", + Short: "Shows details of credentials of a Key Value Store (valkey) instance", + Long: "Shows details of credentials of a Key Value Store (valkey) instance. The password will be shown in plain text in the output.", Args: args.SingleArg(credentialsIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy"`, + `Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy"`, "$ stackit valkey credentials describe xxx --instance-id yyy"), examples.NewExample( - `Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy" in JSON format`, + `Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy" in JSON format`, "$ stackit valkey credentials describe xxx --instance-id yyy --output-format json"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -62,7 +62,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) resp, err := req.Execute() if err != nil { - return fmt.Errorf("describe Valkey credentials: %w", err) + return fmt.Errorf("describe Key Value Store (valkey) credentials: %w", err) } return outputResult(params.Printer, model.OutputFormat, resp) diff --git a/internal/cmd/valkey/credentials/list/list.go b/internal/cmd/valkey/credentials/list/list.go index c3d7b6454..c14af052f 100644 --- a/internal/cmd/valkey/credentials/list/list.go +++ b/internal/cmd/valkey/credentials/list/list.go @@ -33,18 +33,18 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "list", - Short: "Lists all credentials' IDs for a Valkey instance", - Long: "Lists all credentials' IDs for a Valkey instance.", + Short: "Lists all credentials' IDs for a Key Value Store (valkey) instance", + Long: "Lists all credentials' IDs for a Key Value Store (valkey) instance.", Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `List all credentials' IDs for a Valkey instance with ID "xxx"`, + `List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx"`, "$ stackit valkey credentials list --instance-id xxx"), examples.NewExample( - `List all credentials' IDs for a Valkey instance with ID "xxx" in JSON format`, + `List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" in JSON format`, "$ stackit valkey credentials list --instance-id xxx --output-format json"), examples.NewExample( - `List up to 10 credentials' IDs for a Valkey instance with ID "xxx"`, + `List up to 10 credentials' IDs for a Key Value Store (valkey) instance with ID "xxx"`, "$ stackit valkey credentials list --instance-id xxx --limit 10"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -64,7 +64,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) resp, err := req.Execute() if err != nil { - return fmt.Errorf("list Valkey credentials: %w", err) + return fmt.Errorf("list Key Value Store (valkey) credentials: %w", err) } credentials := resp.CredentialsList diff --git a/internal/cmd/valkey/instance/create/create.go b/internal/cmd/valkey/instance/create/create.go index 2e36fd95e..bd91e9a30 100644 --- a/internal/cmd/valkey/instance/create/create.go +++ b/internal/cmd/valkey/instance/create/create.go @@ -62,18 +62,18 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "create", - Short: "Creates a Valkey instance", - Long: "Creates a Valkey instance.", + Short: "Creates a Key Value Store (valkey) instance", + Long: "Creates a Key Value Store (valkey) instance.", Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `Create a Valkey instance with name "my-instance" and specify plan by name and version`, + `Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by name and version`, "$ stackit valkey instance create --name my-instance --plan-name stackit-keyvalue-1.2.10-replica --version 8"), examples.NewExample( - `Create a Valkey instance with name "my-instance" and specify plan by ID`, + `Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by ID`, "$ stackit valkey instance create --name my-instance --plan-id xxx"), examples.NewExample( - `Create a Valkey instance with name "my-instance" and specify IP range which is allowed to access it`, + `Create a Key Value Store (valkey) instance with name "my-instance" and specify IP range which is allowed to access it`, "$ stackit valkey instance create --name my-instance --plan-id xxx --acl 1.2.3.0/24"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -95,7 +95,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { projectLabel = model.ProjectId } - prompt := fmt.Sprintf("Are you sure you want to create a Valkey instance for project %q?", projectLabel) + prompt := fmt.Sprintf("Are you sure you want to create a Key Value Store (valkey) instance for project %q?", projectLabel) err = params.Printer.PromptForConfirmation(prompt) if err != nil { return err @@ -105,13 +105,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req, err := buildRequest(ctx, model, apiClient.DefaultAPI) if err != nil { if _, ok := errors.AsType[*cliErr.DSAInvalidPlanError](err); !ok { - return fmt.Errorf("build Valkey instance creation request: %w", err) + return fmt.Errorf("build Key Value Store (valkey) instance creation request: %w", err) } return err } resp, err := req.Execute() if err != nil { - return fmt.Errorf("create Valkey instance: %w", err) + return fmt.Errorf("create Key Value Store (valkey) instance: %w", err) } instanceId := resp.InstanceId @@ -122,7 +122,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Valkey instance creation: %w", err) + return fmt.Errorf("wait for Key Value Store (valkey) instance creation: %w", err) } } @@ -144,7 +144,7 @@ func configureFlags(cmd *cobra.Command) { cmd.Flags().StringSlice(syslogFlag, []string{}, "Syslog") cmd.Flags().Var(flags.UUIDFlag(), planIdFlag, "Plan ID") cmd.Flags().String(planNameFlag, "", "Plan name") - cmd.Flags().String(versionFlag, "", "Instance Valkey version") + cmd.Flags().String(versionFlag, "", "Instance Key Value Store (valkey) version") cmd.Flags().Int32(minReplicasToWriteFlag, 0, "Minimum number of replicas that must acknowledge a write for it to be accepted") cmd.Flags().String(replBacklogSizeFlag, "", "Replication backlog size (e.g. \"1mb\")") @@ -204,7 +204,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient valkey.Defau offerings, err := apiClient.ListOfferings(ctx, model.ProjectId, model.Region).Execute() if err != nil { - return req, fmt.Errorf("get Valkey offerings: %w", err) + return req, fmt.Errorf("get Key Value Store (valkey) offerings: %w", err) } if model.PlanId == nil { diff --git a/internal/cmd/valkey/instance/delete/delete.go b/internal/cmd/valkey/instance/delete/delete.go index d27268465..6653d1ec4 100644 --- a/internal/cmd/valkey/instance/delete/delete.go +++ b/internal/cmd/valkey/instance/delete/delete.go @@ -32,12 +32,12 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: fmt.Sprintf("delete %s", instanceIdArg), - Short: "Deletes a Valkey instance", - Long: "Deletes a Valkey instance.", + Short: "Deletes a Key Value Store (valkey) instance", + Long: "Deletes a Key Value Store (valkey) instance.", Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Delete a Valkey instance with ID "xxx"`, + `Delete a Key Value Store (valkey) instance with ID "xxx"`, "$ stackit valkey instance delete xxx"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -69,7 +69,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient) err = req.Execute() if err != nil { - return fmt.Errorf("delete Valkey instance: %w", err) + return fmt.Errorf("delete Key Value Store (valkey) instance: %w", err) } // Wait for async operation, if async mode not enabled @@ -79,7 +79,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Valkey instance deletion: %w", err) + return fmt.Errorf("wait for Key Value Store (valkey) instance deletion: %w", err) } } diff --git a/internal/cmd/valkey/instance/describe/describe.go b/internal/cmd/valkey/instance/describe/describe.go index bea55d260..6cbf47b6d 100644 --- a/internal/cmd/valkey/instance/describe/describe.go +++ b/internal/cmd/valkey/instance/describe/describe.go @@ -32,15 +32,15 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: fmt.Sprintf("describe %s", instanceIdArg), - Short: "Shows details of a Valkey instance", - Long: "Shows details of a Valkey instance.", + Short: "Shows details of a Key Value Store (valkey) instance", + Long: "Shows details of a Key Value Store (valkey) instance.", Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Get details of a Valkey instance with ID "xxx"`, + `Get details of a Key Value Store (valkey) instance with ID "xxx"`, "$ stackit valkey instance describe xxx"), examples.NewExample( - `Get details of a Valkey instance with ID "xxx" in JSON format`, + `Get details of a Key Value Store (valkey) instance with ID "xxx" in JSON format`, "$ stackit valkey instance describe xxx --output-format json"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -60,7 +60,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient) resp, err := req.Execute() if err != nil { - return fmt.Errorf("read Valkey instance: %w", err) + return fmt.Errorf("read Key Value Store (valkey) instance: %w", err) } return outputResult(params.Printer, model.OutputFormat, resp) diff --git a/internal/cmd/valkey/instance/instance.go b/internal/cmd/valkey/instance/instance.go index bb0566190..83a1a87fd 100644 --- a/internal/cmd/valkey/instance/instance.go +++ b/internal/cmd/valkey/instance/instance.go @@ -16,8 +16,8 @@ import ( func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "instance", - Short: "Provides functionality for Valkey instances", - Long: "Provides functionality for Valkey instances.", + Short: "Provides functionality for Key Value Store (valkey) instances", + Long: "Provides functionality for Key Value Store (valkey) instances.", Args: args.NoArgs, Run: utils.CmdHelp, } diff --git a/internal/cmd/valkey/instance/list/list.go b/internal/cmd/valkey/instance/list/list.go index e562c44c9..9ab40cca5 100644 --- a/internal/cmd/valkey/instance/list/list.go +++ b/internal/cmd/valkey/instance/list/list.go @@ -32,18 +32,18 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "list", - Short: "Lists all Valkey instances", - Long: "Lists all Valkey instances.", + Short: "Lists all Key Value Store (valkey) instances", + Long: "Lists all Key Value Store (valkey) instances.", Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `List all Valkey instances`, + `List all Key Value Store (valkey) instances`, "$ stackit valkey instance list"), examples.NewExample( - `List all Valkey instances in JSON format`, + `List all Key Value Store (valkey) instances in JSON format`, "$ stackit valkey instance list --output-format json"), examples.NewExample( - `List up to 10 Valkey instances`, + `List up to 10 Key Value Store (valkey) instances`, "$ stackit valkey instance list --limit 10"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -63,7 +63,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient) resp, err := req.Execute() if err != nil { - return fmt.Errorf("get Valkey instances: %w", err) + return fmt.Errorf("get Key Value Store (valkey) instances: %w", err) } instances := resp.Instances diff --git a/internal/cmd/valkey/instance/update/update.go b/internal/cmd/valkey/instance/update/update.go index 5d266331f..a165db8df 100644 --- a/internal/cmd/valkey/instance/update/update.go +++ b/internal/cmd/valkey/instance/update/update.go @@ -63,18 +63,18 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: fmt.Sprintf("update %s", instanceIdArg), - Short: "Updates a Valkey instance", - Long: "Updates a Valkey instance.", + Short: "Updates a Key Value Store (valkey) instance", + Long: "Updates a Key Value Store (valkey) instance.", Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Update the plan of a Valkey instance with ID "xxx" by plan ID`, + `Update the plan of a Key Value Store (valkey) instance with ID "xxx" by plan ID`, "$ stackit valkey instance update xxx --plan-id yyy"), examples.NewExample( - `Update the plan of a Valkey instance with ID "xxx" by name and version`, + `Update the plan of a Key Value Store (valkey) instance with ID "xxx" by name and version`, "$ stackit valkey instance update xxx --plan-name stackit-keyvalue-1.2.10-replica --version 8"), examples.NewExample( - `Update the range of IPs allowed to access a Valkey instance with ID "xxx"`, + `Update the range of IPs allowed to access a Key Value Store (valkey) instance with ID "xxx"`, "$ stackit valkey instance update xxx --acl 1.2.3.0/24"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -106,13 +106,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req, err := buildRequest(ctx, model, apiClient.DefaultAPI) if err != nil { if _, ok := errors.AsType[*cliErr.DSAInvalidPlanError](err); !ok { - return fmt.Errorf("build Valkey instance update request: %w", err) + return fmt.Errorf("build Key Value Store (valkey) instance update request: %w", err) } return err } err = req.Execute() if err != nil { - return fmt.Errorf("update Valkey instance: %w", err) + return fmt.Errorf("update Key Value Store (valkey) instance: %w", err) } // Wait for async operation, if async mode not enabled @@ -122,7 +122,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Valkey instance update: %w", err) + return fmt.Errorf("wait for Key Value Store (valkey) instance update: %w", err) } } @@ -143,7 +143,7 @@ func configureFlags(cmd *cobra.Command) { cmd.Flags().StringSlice(syslogFlag, []string{}, "Syslog") cmd.Flags().Var(flags.UUIDFlag(), planIdFlag, "Plan ID") cmd.Flags().String(planNameFlag, "", "Plan name") - cmd.Flags().String(versionFlag, "", "Instance Valkey version") + cmd.Flags().String(versionFlag, "", "Instance Key Value Store (valkey) version") cmd.Flags().Int32(minReplicasToWriteFlag, 0, "Minimum number of replicas that must acknowledge a write for it to be accepted") cmd.Flags().String(replBacklogSizeFlag, "", "Replication backlog size (e.g. \"1mb\")") @@ -218,7 +218,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient valkey.Defau if model.PlanId != nil || model.PlanName != "" { offerings, err := apiClient.ListOfferings(ctx, model.ProjectId, model.Region).Execute() if err != nil { - return req, fmt.Errorf("get Valkey offerings: %w", err) + return req, fmt.Errorf("get Key Value Store (valkey) offerings: %w", err) } if model.PlanId != nil { diff --git a/internal/cmd/valkey/plans/plans.go b/internal/cmd/valkey/plans/plans.go index 2a9a0486d..1b5a4a049 100644 --- a/internal/cmd/valkey/plans/plans.go +++ b/internal/cmd/valkey/plans/plans.go @@ -31,19 +31,19 @@ type inputModel struct { func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "plans", - Short: "Lists all Valkey service plans", - Long: "Lists all Valkey service plans.", + Short: "Lists all Key Value Store (valkey) service plans", + Long: "Lists all Key Value Store (valkey) service plans.", Args: args.NoArgs, Example: examples.Build( examples.NewExample( - "Lists all Valkey service plans", + "Lists all Key Value Store (valkey) service plans", "$ stackit valkey plans", ), examples.NewExample( - `List all Valkey service plans in JSON format`, + `List all Key Value Store (valkey) service plans in JSON format`, "$ stackit valkey plans --output-format json"), examples.NewExample( - `List up to 10 Valkey service plans`, + `List up to 10 Key Value Store (valkey) service plans`, "$ stackit valkey plans --limit 10"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -61,7 +61,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiclient) resp, err := req.Execute() if err != nil { - return fmt.Errorf("get Valkey service plans: %w", err) + return fmt.Errorf("get Key Value Store (valkey) service plans: %w", err) } plans := resp.Offerings diff --git a/internal/cmd/valkey/valkey.go b/internal/cmd/valkey/valkey.go index 016bc7ae0..b9a59b783 100644 --- a/internal/cmd/valkey/valkey.go +++ b/internal/cmd/valkey/valkey.go @@ -14,8 +14,8 @@ import ( func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: "valkey", - Short: "Provides functionality for Valkey", - Long: "Provides functionality for Valkey.", + Short: "Provides functionality for Key Value Store (valkey)", + Long: "Provides functionality for Key Value Store (valkey).", Args: args.NoArgs, Run: utils.CmdHelp, } diff --git a/internal/pkg/services/valkey/utils/utils.go b/internal/pkg/services/valkey/utils/utils.go index 362d265ec..083b33996 100644 --- a/internal/pkg/services/valkey/utils/utils.go +++ b/internal/pkg/services/valkey/utils/utils.go @@ -65,7 +65,7 @@ func LoadPlanId(planName, version string, offerings *valkey.ListOfferingsRespons func GetInstanceName(ctx context.Context, apiClient valkey.DefaultAPI, projectId, instanceId, region string) (string, error) { resp, err := apiClient.GetInstance(ctx, projectId, region, instanceId).Execute() if err != nil { - return "", fmt.Errorf("get Valkey instance: %w", err) + return "", fmt.Errorf("get Key Value Store (valkey) instance: %w", err) } return resp.Name, nil } @@ -73,7 +73,7 @@ func GetInstanceName(ctx context.Context, apiClient valkey.DefaultAPI, projectId func GetCredentialsUsername(ctx context.Context, apiClient valkey.DefaultAPI, projectId, instanceId, credentialsId, region string) (string, error) { resp, err := apiClient.GetCredentials(ctx, projectId, region, instanceId, credentialsId).Execute() if err != nil { - return "", fmt.Errorf("get Valkey credentials: %w", err) + return "", fmt.Errorf("get Key Value Store (valkey) credentials: %w", err) } if resp.Raw == nil { return "", nil From dbebcb6f5021a35e8f5d7f51e3a646098afaa24d Mon Sep 17 00:00:00 2001 From: GokceGK Date: Wed, 9 Sep 2026 08:22:32 +0200 Subject: [PATCH 2/3] feat(valkey): address review comments relates to STACKITTPR-845 --- docs/stackit_valkey_credentials_create.md | 4 ++-- docs/stackit_valkey_credentials_delete.md | 2 +- docs/stackit_valkey_credentials_describe.md | 4 ++-- docs/stackit_valkey_credentials_list.md | 6 +++--- docs/stackit_valkey_instance_create.md | 8 ++++---- docs/stackit_valkey_instance_delete.md | 2 +- docs/stackit_valkey_instance_describe.md | 4 ++-- docs/stackit_valkey_instance_list.md | 6 +++--- docs/stackit_valkey_instance_update.md | 8 ++++---- docs/stackit_valkey_plans.md | 6 +++--- .../cmd/valkey/credentials/create/create.go | 8 ++++---- .../cmd/valkey/credentials/delete/delete.go | 4 ++-- .../valkey/credentials/describe/describe.go | 6 +++--- internal/cmd/valkey/credentials/list/list.go | 8 ++++---- internal/cmd/valkey/instance/create/create.go | 18 +++++++++--------- internal/cmd/valkey/instance/delete/delete.go | 6 +++--- .../cmd/valkey/instance/describe/describe.go | 6 +++--- internal/cmd/valkey/instance/list/list.go | 8 ++++---- internal/cmd/valkey/instance/update/update.go | 16 ++++++++-------- internal/cmd/valkey/plans/plans.go | 8 ++++---- 20 files changed, 69 insertions(+), 69 deletions(-) diff --git a/docs/stackit_valkey_credentials_create.md b/docs/stackit_valkey_credentials_create.md index c610a7b20..df4984458 100644 --- a/docs/stackit_valkey_credentials_create.md +++ b/docs/stackit_valkey_credentials_create.md @@ -13,10 +13,10 @@ stackit valkey credentials create [flags] ### Examples ``` - Create credentials for a Key Value Store (valkey) instance with ID "xxx" + Create credentials for a Valkey instance with ID "xxx" $ stackit valkey credentials create --instance-id xxx - Create credentials for a Key Value Store (valkey) instance and show the password in the output + Create credentials for a Valkey instance and show the password in the output $ stackit valkey credentials create --instance-id xxx --show-password ``` diff --git a/docs/stackit_valkey_credentials_delete.md b/docs/stackit_valkey_credentials_delete.md index e4bac86cb..3ab3d9fdb 100644 --- a/docs/stackit_valkey_credentials_delete.md +++ b/docs/stackit_valkey_credentials_delete.md @@ -13,7 +13,7 @@ stackit valkey credentials delete CREDENTIALS_ID [flags] ### Examples ``` - Delete credentials with ID "xxx" of a Key Value Store (valkey) instance with ID "yyy" + Delete credentials with ID "xxx" of a Valkey instance with ID "yyy" $ stackit valkey credentials delete xxx --instance-id yyy ``` diff --git a/docs/stackit_valkey_credentials_describe.md b/docs/stackit_valkey_credentials_describe.md index 2ed16e577..8b4833e4d 100644 --- a/docs/stackit_valkey_credentials_describe.md +++ b/docs/stackit_valkey_credentials_describe.md @@ -13,10 +13,10 @@ stackit valkey credentials describe CREDENTIALS_ID [flags] ### Examples ``` - Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy" + Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy" $ stackit valkey credentials describe xxx --instance-id yyy - Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy" in JSON format + Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy" in JSON format $ stackit valkey credentials describe xxx --instance-id yyy --output-format json ``` diff --git a/docs/stackit_valkey_credentials_list.md b/docs/stackit_valkey_credentials_list.md index b95bb7304..449665703 100644 --- a/docs/stackit_valkey_credentials_list.md +++ b/docs/stackit_valkey_credentials_list.md @@ -13,13 +13,13 @@ stackit valkey credentials list [flags] ### Examples ``` - List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" + List all credentials' IDs for a Valkey instance with ID "xxx" $ stackit valkey credentials list --instance-id xxx - List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" in JSON format + List all credentials' IDs for a Valkey instance with ID "xxx" in JSON format $ stackit valkey credentials list --instance-id xxx --output-format json - List up to 10 credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" + List up to 10 credentials' IDs for a Valkey instance with ID "xxx" $ stackit valkey credentials list --instance-id xxx --limit 10 ``` diff --git a/docs/stackit_valkey_instance_create.md b/docs/stackit_valkey_instance_create.md index 392aedb4f..a3da1f79b 100644 --- a/docs/stackit_valkey_instance_create.md +++ b/docs/stackit_valkey_instance_create.md @@ -13,13 +13,13 @@ stackit valkey instance create [flags] ### Examples ``` - Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by name and version + Create a Valkey instance with name "my-instance" and specify plan by name and version $ stackit valkey instance create --name my-instance --plan-name stackit-keyvalue-1.2.10-replica --version 8 - Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by ID + Create a Valkey instance with name "my-instance" and specify plan by ID $ stackit valkey instance create --name my-instance --plan-id xxx - Create a Key Value Store (valkey) instance with name "my-instance" and specify IP range which is allowed to access it + Create a Valkey instance with name "my-instance" and specify IP range which is allowed to access it $ stackit valkey instance create --name my-instance --plan-id xxx --acl 1.2.3.0/24 ``` @@ -39,7 +39,7 @@ stackit valkey instance create [flags] --plan-name string Plan name --repl-backlog-size string Replication backlog size (e.g. "1mb") --syslog strings Syslog - --version string Instance Key Value Store (valkey) version + --version string Instance Valkey version ``` ### Options inherited from parent commands diff --git a/docs/stackit_valkey_instance_delete.md b/docs/stackit_valkey_instance_delete.md index 603680bf9..39e6b7cd8 100644 --- a/docs/stackit_valkey_instance_delete.md +++ b/docs/stackit_valkey_instance_delete.md @@ -13,7 +13,7 @@ stackit valkey instance delete INSTANCE_ID [flags] ### Examples ``` - Delete a Key Value Store (valkey) instance with ID "xxx" + Delete a Valkey instance with ID "xxx" $ stackit valkey instance delete xxx ``` diff --git a/docs/stackit_valkey_instance_describe.md b/docs/stackit_valkey_instance_describe.md index ff233cbf5..1669f13c3 100644 --- a/docs/stackit_valkey_instance_describe.md +++ b/docs/stackit_valkey_instance_describe.md @@ -13,10 +13,10 @@ stackit valkey instance describe INSTANCE_ID [flags] ### Examples ``` - Get details of a Key Value Store (valkey) instance with ID "xxx" + Get details of a Valkey instance with ID "xxx" $ stackit valkey instance describe xxx - Get details of a Key Value Store (valkey) instance with ID "xxx" in JSON format + Get details of a Valkey instance with ID "xxx" in JSON format $ stackit valkey instance describe xxx --output-format json ``` diff --git a/docs/stackit_valkey_instance_list.md b/docs/stackit_valkey_instance_list.md index 25dbd81b3..df72f56de 100644 --- a/docs/stackit_valkey_instance_list.md +++ b/docs/stackit_valkey_instance_list.md @@ -13,13 +13,13 @@ stackit valkey instance list [flags] ### Examples ``` - List all Key Value Store (valkey) instances + List all Valkey instances $ stackit valkey instance list - List all Key Value Store (valkey) instances in JSON format + List all Valkey instances in JSON format $ stackit valkey instance list --output-format json - List up to 10 Key Value Store (valkey) instances + List up to 10 Valkey instances $ stackit valkey instance list --limit 10 ``` diff --git a/docs/stackit_valkey_instance_update.md b/docs/stackit_valkey_instance_update.md index a5094222f..8d4010ff7 100644 --- a/docs/stackit_valkey_instance_update.md +++ b/docs/stackit_valkey_instance_update.md @@ -13,13 +13,13 @@ stackit valkey instance update INSTANCE_ID [flags] ### Examples ``` - Update the plan of a Key Value Store (valkey) instance with ID "xxx" by plan ID + Update the plan of a Valkey instance with ID "xxx" by plan ID $ stackit valkey instance update xxx --plan-id yyy - Update the plan of a Key Value Store (valkey) instance with ID "xxx" by name and version + Update the plan of a Valkey instance with ID "xxx" by name and version $ stackit valkey instance update xxx --plan-name stackit-keyvalue-1.2.10-replica --version 8 - Update the range of IPs allowed to access a Key Value Store (valkey) instance with ID "xxx" + Update the range of IPs allowed to access a Valkey instance with ID "xxx" $ stackit valkey instance update xxx --acl 1.2.3.0/24 ``` @@ -38,7 +38,7 @@ stackit valkey instance update INSTANCE_ID [flags] --plan-name string Plan name --repl-backlog-size string Replication backlog size (e.g. "1mb") --syslog strings Syslog - --version string Instance Key Value Store (valkey) version + --version string Instance Valkey version ``` ### Options inherited from parent commands diff --git a/docs/stackit_valkey_plans.md b/docs/stackit_valkey_plans.md index 3f0e57b5b..480d228dd 100644 --- a/docs/stackit_valkey_plans.md +++ b/docs/stackit_valkey_plans.md @@ -13,13 +13,13 @@ stackit valkey plans [flags] ### Examples ``` - Lists all Key Value Store (valkey) service plans + Lists all Valkey service plans $ stackit valkey plans - List all Key Value Store (valkey) service plans in JSON format + List all Valkey service plans in JSON format $ stackit valkey plans --output-format json - List up to 10 Key Value Store (valkey) service plans + List up to 10 Valkey service plans $ stackit valkey plans --limit 10 ``` diff --git a/internal/cmd/valkey/credentials/create/create.go b/internal/cmd/valkey/credentials/create/create.go index a975e5b43..51e04c65b 100644 --- a/internal/cmd/valkey/credentials/create/create.go +++ b/internal/cmd/valkey/credentials/create/create.go @@ -40,10 +40,10 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `Create credentials for a Key Value Store (valkey) instance with ID "xxx"`, + `Create credentials for a Valkey instance with ID "xxx"`, "$ stackit valkey credentials create --instance-id xxx"), examples.NewExample( - `Create credentials for a Key Value Store (valkey) instance and show the password in the output`, + `Create credentials for a Valkey instance and show the password in the output`, "$ stackit valkey credentials create --instance-id xxx --show-password"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -75,7 +75,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) resp, err := req.Execute() if err != nil { - return fmt.Errorf("create Key Value Store (valkey) credentials: %w", err) + return fmt.Errorf("create Valkey credentials: %w", err) } credentialsId := resp.Id @@ -87,7 +87,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Key Value Store (valkey) credentials creation: %w", err) + return fmt.Errorf("wait for Valkey credentials creation: %w", err) } } diff --git a/internal/cmd/valkey/credentials/delete/delete.go b/internal/cmd/valkey/credentials/delete/delete.go index 226a8a73b..194733664 100644 --- a/internal/cmd/valkey/credentials/delete/delete.go +++ b/internal/cmd/valkey/credentials/delete/delete.go @@ -39,7 +39,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.SingleArg(credentialsIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Delete credentials with ID "xxx" of a Key Value Store (valkey) instance with ID "yyy"`, + `Delete credentials with ID "xxx" of a Valkey instance with ID "yyy"`, "$ stackit valkey credentials delete xxx --instance-id yyy"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -77,7 +77,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) err = req.Execute() if err != nil { - return fmt.Errorf("delete Key Value Store (valkey) credentials: %w", err) + return fmt.Errorf("delete Valkey credentials: %w", err) } params.Printer.Info("Deleted credentials %s of instance %q\n", credentialsLabel, instanceLabel) diff --git a/internal/cmd/valkey/credentials/describe/describe.go b/internal/cmd/valkey/credentials/describe/describe.go index 709149d79..1aa3987fe 100644 --- a/internal/cmd/valkey/credentials/describe/describe.go +++ b/internal/cmd/valkey/credentials/describe/describe.go @@ -39,10 +39,10 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.SingleArg(credentialsIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy"`, + `Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy"`, "$ stackit valkey credentials describe xxx --instance-id yyy"), examples.NewExample( - `Get details of credentials with ID "xxx" from a Key Value Store (valkey) instance with ID "yyy" in JSON format`, + `Get details of credentials with ID "xxx" from a Valkey instance with ID "yyy" in JSON format`, "$ stackit valkey credentials describe xxx --instance-id yyy --output-format json"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -62,7 +62,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) resp, err := req.Execute() if err != nil { - return fmt.Errorf("describe Key Value Store (valkey) credentials: %w", err) + return fmt.Errorf("describe Valkey credentials: %w", err) } return outputResult(params.Printer, model.OutputFormat, resp) diff --git a/internal/cmd/valkey/credentials/list/list.go b/internal/cmd/valkey/credentials/list/list.go index c14af052f..16a9b427b 100644 --- a/internal/cmd/valkey/credentials/list/list.go +++ b/internal/cmd/valkey/credentials/list/list.go @@ -38,13 +38,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx"`, + `List all credentials' IDs for a Valkey instance with ID "xxx"`, "$ stackit valkey credentials list --instance-id xxx"), examples.NewExample( - `List all credentials' IDs for a Key Value Store (valkey) instance with ID "xxx" in JSON format`, + `List all credentials' IDs for a Valkey instance with ID "xxx" in JSON format`, "$ stackit valkey credentials list --instance-id xxx --output-format json"), examples.NewExample( - `List up to 10 credentials' IDs for a Key Value Store (valkey) instance with ID "xxx"`, + `List up to 10 credentials' IDs for a Valkey instance with ID "xxx"`, "$ stackit valkey credentials list --instance-id xxx --limit 10"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -64,7 +64,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient.DefaultAPI) resp, err := req.Execute() if err != nil { - return fmt.Errorf("list Key Value Store (valkey) credentials: %w", err) + return fmt.Errorf("list Valkey credentials: %w", err) } credentials := resp.CredentialsList diff --git a/internal/cmd/valkey/instance/create/create.go b/internal/cmd/valkey/instance/create/create.go index bd91e9a30..39553272c 100644 --- a/internal/cmd/valkey/instance/create/create.go +++ b/internal/cmd/valkey/instance/create/create.go @@ -67,13 +67,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by name and version`, + `Create a Valkey instance with name "my-instance" and specify plan by name and version`, "$ stackit valkey instance create --name my-instance --plan-name stackit-keyvalue-1.2.10-replica --version 8"), examples.NewExample( - `Create a Key Value Store (valkey) instance with name "my-instance" and specify plan by ID`, + `Create a Valkey instance with name "my-instance" and specify plan by ID`, "$ stackit valkey instance create --name my-instance --plan-id xxx"), examples.NewExample( - `Create a Key Value Store (valkey) instance with name "my-instance" and specify IP range which is allowed to access it`, + `Create a Valkey instance with name "my-instance" and specify IP range which is allowed to access it`, "$ stackit valkey instance create --name my-instance --plan-id xxx --acl 1.2.3.0/24"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -95,7 +95,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { projectLabel = model.ProjectId } - prompt := fmt.Sprintf("Are you sure you want to create a Key Value Store (valkey) instance for project %q?", projectLabel) + prompt := fmt.Sprintf("Are you sure you want to create a Valkey instance for project %q?", projectLabel) err = params.Printer.PromptForConfirmation(prompt) if err != nil { return err @@ -105,13 +105,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req, err := buildRequest(ctx, model, apiClient.DefaultAPI) if err != nil { if _, ok := errors.AsType[*cliErr.DSAInvalidPlanError](err); !ok { - return fmt.Errorf("build Key Value Store (valkey) instance creation request: %w", err) + return fmt.Errorf("build Valkey instance creation request: %w", err) } return err } resp, err := req.Execute() if err != nil { - return fmt.Errorf("create Key Value Store (valkey) instance: %w", err) + return fmt.Errorf("create Valkey instance: %w", err) } instanceId := resp.InstanceId @@ -122,7 +122,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Key Value Store (valkey) instance creation: %w", err) + return fmt.Errorf("wait for Valkey instance creation: %w", err) } } @@ -144,7 +144,7 @@ func configureFlags(cmd *cobra.Command) { cmd.Flags().StringSlice(syslogFlag, []string{}, "Syslog") cmd.Flags().Var(flags.UUIDFlag(), planIdFlag, "Plan ID") cmd.Flags().String(planNameFlag, "", "Plan name") - cmd.Flags().String(versionFlag, "", "Instance Key Value Store (valkey) version") + cmd.Flags().String(versionFlag, "", "Instance Valkey version") cmd.Flags().Int32(minReplicasToWriteFlag, 0, "Minimum number of replicas that must acknowledge a write for it to be accepted") cmd.Flags().String(replBacklogSizeFlag, "", "Replication backlog size (e.g. \"1mb\")") @@ -204,7 +204,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient valkey.Defau offerings, err := apiClient.ListOfferings(ctx, model.ProjectId, model.Region).Execute() if err != nil { - return req, fmt.Errorf("get Key Value Store (valkey) offerings: %w", err) + return req, fmt.Errorf("get Valkey offerings: %w", err) } if model.PlanId == nil { diff --git a/internal/cmd/valkey/instance/delete/delete.go b/internal/cmd/valkey/instance/delete/delete.go index 6653d1ec4..793deb0be 100644 --- a/internal/cmd/valkey/instance/delete/delete.go +++ b/internal/cmd/valkey/instance/delete/delete.go @@ -37,7 +37,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Delete a Key Value Store (valkey) instance with ID "xxx"`, + `Delete a Valkey instance with ID "xxx"`, "$ stackit valkey instance delete xxx"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -69,7 +69,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient) err = req.Execute() if err != nil { - return fmt.Errorf("delete Key Value Store (valkey) instance: %w", err) + return fmt.Errorf("delete Valkey instance: %w", err) } // Wait for async operation, if async mode not enabled @@ -79,7 +79,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Key Value Store (valkey) instance deletion: %w", err) + return fmt.Errorf("wait for Valkey instance deletion: %w", err) } } diff --git a/internal/cmd/valkey/instance/describe/describe.go b/internal/cmd/valkey/instance/describe/describe.go index 6cbf47b6d..d6219bb50 100644 --- a/internal/cmd/valkey/instance/describe/describe.go +++ b/internal/cmd/valkey/instance/describe/describe.go @@ -37,10 +37,10 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Get details of a Key Value Store (valkey) instance with ID "xxx"`, + `Get details of a Valkey instance with ID "xxx"`, "$ stackit valkey instance describe xxx"), examples.NewExample( - `Get details of a Key Value Store (valkey) instance with ID "xxx" in JSON format`, + `Get details of a Valkey instance with ID "xxx" in JSON format`, "$ stackit valkey instance describe xxx --output-format json"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -60,7 +60,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient) resp, err := req.Execute() if err != nil { - return fmt.Errorf("read Key Value Store (valkey) instance: %w", err) + return fmt.Errorf("read Valkey instance: %w", err) } return outputResult(params.Printer, model.OutputFormat, resp) diff --git a/internal/cmd/valkey/instance/list/list.go b/internal/cmd/valkey/instance/list/list.go index 9ab40cca5..52dfb53bf 100644 --- a/internal/cmd/valkey/instance/list/list.go +++ b/internal/cmd/valkey/instance/list/list.go @@ -37,13 +37,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.NoArgs, Example: examples.Build( examples.NewExample( - `List all Key Value Store (valkey) instances`, + `List all Valkey instances`, "$ stackit valkey instance list"), examples.NewExample( - `List all Key Value Store (valkey) instances in JSON format`, + `List all Valkey instances in JSON format`, "$ stackit valkey instance list --output-format json"), examples.NewExample( - `List up to 10 Key Value Store (valkey) instances`, + `List up to 10 Valkey instances`, "$ stackit valkey instance list --limit 10"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -63,7 +63,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiClient) resp, err := req.Execute() if err != nil { - return fmt.Errorf("get Key Value Store (valkey) instances: %w", err) + return fmt.Errorf("get Valkey instances: %w", err) } instances := resp.Instances diff --git a/internal/cmd/valkey/instance/update/update.go b/internal/cmd/valkey/instance/update/update.go index a165db8df..477ea7c0b 100644 --- a/internal/cmd/valkey/instance/update/update.go +++ b/internal/cmd/valkey/instance/update/update.go @@ -68,13 +68,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( examples.NewExample( - `Update the plan of a Key Value Store (valkey) instance with ID "xxx" by plan ID`, + `Update the plan of a Valkey instance with ID "xxx" by plan ID`, "$ stackit valkey instance update xxx --plan-id yyy"), examples.NewExample( - `Update the plan of a Key Value Store (valkey) instance with ID "xxx" by name and version`, + `Update the plan of a Valkey instance with ID "xxx" by name and version`, "$ stackit valkey instance update xxx --plan-name stackit-keyvalue-1.2.10-replica --version 8"), examples.NewExample( - `Update the range of IPs allowed to access a Key Value Store (valkey) instance with ID "xxx"`, + `Update the range of IPs allowed to access a Valkey instance with ID "xxx"`, "$ stackit valkey instance update xxx --acl 1.2.3.0/24"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -106,13 +106,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req, err := buildRequest(ctx, model, apiClient.DefaultAPI) if err != nil { if _, ok := errors.AsType[*cliErr.DSAInvalidPlanError](err); !ok { - return fmt.Errorf("build Key Value Store (valkey) instance update request: %w", err) + return fmt.Errorf("build Valkey instance update request: %w", err) } return err } err = req.Execute() if err != nil { - return fmt.Errorf("update Key Value Store (valkey) instance: %w", err) + return fmt.Errorf("update Valkey instance: %w", err) } // Wait for async operation, if async mode not enabled @@ -122,7 +122,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for Key Value Store (valkey) instance update: %w", err) + return fmt.Errorf("wait for Valkey instance update: %w", err) } } @@ -143,7 +143,7 @@ func configureFlags(cmd *cobra.Command) { cmd.Flags().StringSlice(syslogFlag, []string{}, "Syslog") cmd.Flags().Var(flags.UUIDFlag(), planIdFlag, "Plan ID") cmd.Flags().String(planNameFlag, "", "Plan name") - cmd.Flags().String(versionFlag, "", "Instance Key Value Store (valkey) version") + cmd.Flags().String(versionFlag, "", "Instance Valkey version") cmd.Flags().Int32(minReplicasToWriteFlag, 0, "Minimum number of replicas that must acknowledge a write for it to be accepted") cmd.Flags().String(replBacklogSizeFlag, "", "Replication backlog size (e.g. \"1mb\")") @@ -218,7 +218,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient valkey.Defau if model.PlanId != nil || model.PlanName != "" { offerings, err := apiClient.ListOfferings(ctx, model.ProjectId, model.Region).Execute() if err != nil { - return req, fmt.Errorf("get Key Value Store (valkey) offerings: %w", err) + return req, fmt.Errorf("get Valkey offerings: %w", err) } if model.PlanId != nil { diff --git a/internal/cmd/valkey/plans/plans.go b/internal/cmd/valkey/plans/plans.go index 1b5a4a049..622e03ec1 100644 --- a/internal/cmd/valkey/plans/plans.go +++ b/internal/cmd/valkey/plans/plans.go @@ -36,14 +36,14 @@ func NewCmd(params *types.CmdParams) *cobra.Command { Args: args.NoArgs, Example: examples.Build( examples.NewExample( - "Lists all Key Value Store (valkey) service plans", + "Lists all Valkey service plans", "$ stackit valkey plans", ), examples.NewExample( - `List all Key Value Store (valkey) service plans in JSON format`, + `List all Valkey service plans in JSON format`, "$ stackit valkey plans --output-format json"), examples.NewExample( - `List up to 10 Key Value Store (valkey) service plans`, + `List up to 10 Valkey service plans`, "$ stackit valkey plans --limit 10"), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -61,7 +61,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { req := buildRequest(ctx, model, apiclient) resp, err := req.Execute() if err != nil { - return fmt.Errorf("get Key Value Store (valkey) service plans: %w", err) + return fmt.Errorf("get Valkey service plans: %w", err) } plans := resp.Offerings From ae8e4d4c705ad401a3d2adc4566d7aa25d0e3cab Mon Sep 17 00:00:00 2001 From: GokceGK Date: Wed, 9 Sep 2026 08:26:11 +0200 Subject: [PATCH 3/3] feat(valkey): address review comments relates to STACKITTPR-845 --- internal/pkg/services/valkey/utils/utils.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/pkg/services/valkey/utils/utils.go b/internal/pkg/services/valkey/utils/utils.go index 083b33996..362d265ec 100644 --- a/internal/pkg/services/valkey/utils/utils.go +++ b/internal/pkg/services/valkey/utils/utils.go @@ -65,7 +65,7 @@ func LoadPlanId(planName, version string, offerings *valkey.ListOfferingsRespons func GetInstanceName(ctx context.Context, apiClient valkey.DefaultAPI, projectId, instanceId, region string) (string, error) { resp, err := apiClient.GetInstance(ctx, projectId, region, instanceId).Execute() if err != nil { - return "", fmt.Errorf("get Key Value Store (valkey) instance: %w", err) + return "", fmt.Errorf("get Valkey instance: %w", err) } return resp.Name, nil } @@ -73,7 +73,7 @@ func GetInstanceName(ctx context.Context, apiClient valkey.DefaultAPI, projectId func GetCredentialsUsername(ctx context.Context, apiClient valkey.DefaultAPI, projectId, instanceId, credentialsId, region string) (string, error) { resp, err := apiClient.GetCredentials(ctx, projectId, region, instanceId, credentialsId).Execute() if err != nil { - return "", fmt.Errorf("get Key Value Store (valkey) credentials: %w", err) + return "", fmt.Errorf("get Valkey credentials: %w", err) } if resp.Raw == nil { return "", nil