From 803e76f9eebae5ee82f3961ac8cb1934ebec53ed Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 21 Aug 2026 10:16:57 +0000 Subject: [PATCH] test: migrate `stats/base/dists/normal/mean` to ULP-based assertions Replace computed relative-tolerance comparisons with `isAlmostSameValue` ULP-based assertions in the fixture loops. Both the JavaScript and the C implementations return `mu` verbatim, so every fixture value matches the Julia reference exactly. The measured minimum bound is thus 0 ULP for both test.js and test.native.js, which is the tightest bound expressible. Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- .../stats/base/dists/normal/mean/test/test.js | 13 ++----------- .../base/dists/normal/mean/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.js index 2091e9fb9aaf..7d84f9f707e4 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var mean = require( './../lib' ); @@ -76,9 +75,7 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the expected value of a normal distribution', function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var y; var i; @@ -89,13 +86,7 @@ tape( 'the function returns the expected value of a normal distribution', functi for ( i = 0; i < mu.length; i++ ) { y = mean( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.native.js index a6e19a8f9dcc..75dc7336f841 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/mean/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -85,9 +84,7 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the expected value of a normal distribution', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var y; var i; @@ -98,13 +95,7 @@ tape( 'the function returns the expected value of a normal distribution', opts, for ( i = 0; i < mu.length; i++ ) { y = mean( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end();