Skip to content

Commit 4e4e4ba

Browse files
committed
fix(webapp): preserve tooltip trigger semantics
1 parent d877905 commit 4e4e4ba

6 files changed

Lines changed: 6 additions & 1 deletion

File tree

apps/webapp/app/components/AskAI.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -543,6 +543,7 @@ function ChatInterface({ initialQuery }: { initialQuery?: string }) {
543543
/>
544544
{isGeneratingAnswer ? (
545545
<SimpleTooltip
546+
asChild
546547
button={
547548
<button
548549
type="button"

apps/webapp/app/components/code/TSQLResultsTable.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -857,6 +857,7 @@ function CopyableCell({
857857
>
858858
<span className="flex items-center truncate">{children}</span>
859859
<SimpleTooltip
860+
asChild
860861
button={
861862
<button
862863
type="button"

apps/webapp/app/components/dashboard-agent/tooltip-accessible-name.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ const NO_AS_CHILD_BASELINE = new Set([
6060
"app/components/GitMetadata.tsx::LinkButton",
6161
"app/components/code/TSQLResultsTable.tsx::TextLink",
6262
"app/components/integrations/VercelLink.tsx::LinkButton",
63-
"app/components/primitives/CopyButton.tsx::Button",
6463
"app/components/runs/v3/RunTag.tsx::Link",
6564
"app/components/runs/v3/TaskRunsTable.tsx::DialogTrigger",
6665
"app/routes/account.tokens/route.tsx::DialogTrigger",

apps/webapp/app/components/primitives/CopyButton.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export function CopyButton({
9797
return (
9898
<span className={className}>
9999
<SimpleTooltip
100+
asChild
100101
button={button}
101102
content={copied ? "Copied!" : "Copy"}
102103
className="font-sans"

apps/webapp/app/components/primitives/Table.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,7 @@ export const CopyableTableCell = forwardRef<HTMLTableCellElement, CopyableTableC
487487
>
488488
{children}
489489
<SimpleTooltip
490+
asChild
490491
button={
491492
<button
492493
type="button"

apps/webapp/app/components/runs/v3/RunTag.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ function CopyButton({ textToCopy, isHovered }: { textToCopy: string; isHovered:
113113

114114
return (
115115
<SimpleTooltip
116+
asChild
116117
button={
117118
<button
118119
type="button"
@@ -160,6 +161,7 @@ function DeleteButton({
160161

161162
return (
162163
<SimpleTooltip
164+
asChild
163165
button={
164166
<button
165167
type="button"

0 commit comments

Comments
 (0)