diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c index 253f94da20c..bed161cb874 100644 --- a/wolfcrypt/src/asn.c +++ b/wolfcrypt/src/asn.c @@ -81,6 +81,9 @@ ASN Options: * WOLFSSL_NO_OCSP_DATE_CHECK: Disable date checks for OCSP responses. This may be required when the system's real-time clock is not very accurate. It is recommended to enforce the nonce check instead if possible. + If you are enabling WOLFSSL_NO_OCSP_DATE_CHECK because of an + inaccurate clock you can also consider WOLFSSL_AFTER_DATE_CLOCK_SKEW/ + WOLFSSL_BEFORE_DATE_CLOCK_SKEW. * WOLFSSL_NO_CRL_DATE_CHECK: Disable date checks for CRL's. * WOLFSSL_NO_CRL_NEXT_DATE: Do not fail if CRL next date is missing * WOLFSSL_FORCE_OCSP_NONCE_CHECK: Require nonces to be available in OCSP @@ -36012,6 +36015,8 @@ static int DecodeSingleResponse(const byte* source, word32* ioIndex, /* Store the thisDate format - only one possible. */ cs->thisDateFormat = ASN_GENERALIZED_TIME; #if !defined(NO_ASN_TIME_CHECK) && !defined(WOLFSSL_NO_OCSP_DATE_CHECK) + /* If you are enabling WOLFSSL_NO_OCSP_DATE_CHECK because of an + * inaccurate clock consider WOLFSSL_BEFORE_DATE_CLOCK_SKEW. */ /* Check date is a valid string and ASN_BEFORE now. */ if ((! AsnSkipDateCheck) && !XVALIDATE_DATE(cs->thisDate, ASN_GENERALIZED_TIME, ASN_BEFORE, @@ -36038,6 +36043,8 @@ static int DecodeSingleResponse(const byte* source, word32* ioIndex, /* Store the nextDate format - only one possible. */ cs->nextDateFormat = ASN_GENERALIZED_TIME; #if !defined(NO_ASN_TIME_CHECK) && !defined(WOLFSSL_NO_OCSP_DATE_CHECK) + /* If you are enabling WOLFSSL_NO_OCSP_DATE_CHECK because of an + * inaccurate clock consider WOLFSSL_AFTER_DATE_CLOCK_SKEW. */ /* Check date is a valid string and ASN_AFTER now. */ if ((! AsnSkipDateCheck) && !XVALIDATE_DATE(cs->nextDate, ASN_GENERALIZED_TIME, ASN_AFTER, diff --git a/wolfcrypt/src/asn_orig.c b/wolfcrypt/src/asn_orig.c index a77382f4bb0..7bfafe0c93d 100644 --- a/wolfcrypt/src/asn_orig.c +++ b/wolfcrypt/src/asn_orig.c @@ -8453,6 +8453,8 @@ static int DecodeSingleResponse(byte* source, word32* ioIndex, word32 size, #ifndef NO_ASN_TIME_CHECK #ifndef WOLFSSL_NO_OCSP_DATE_CHECK + /* If you are enabling WOLFSSL_NO_OCSP_DATE_CHECK because of an inaccurate + * clock consider WOLFSSL_BEFORE_DATE_CLOCK_SKEW. */ if ((! AsnSkipDateCheck) && !XVALIDATE_DATE(single->status->thisDate, single->status->thisDateFormat, ASN_BEFORE, MAX_DATE_SIZE)) return ASN_BEFORE_DATE_E; @@ -8490,6 +8492,8 @@ static int DecodeSingleResponse(byte* source, word32* ioIndex, word32 size, #ifndef NO_ASN_TIME_CHECK #ifndef WOLFSSL_NO_OCSP_DATE_CHECK + /* If you are enabling WOLFSSL_NO_OCSP_DATE_CHECK because of an + * inaccurate clock consider WOLFSSL_AFTER_DATE_CLOCK_SKEW. */ if ((! AsnSkipDateCheck) && !XVALIDATE_DATE(single->status->nextDate, single->status->nextDateFormat, ASN_AFTER, MAX_DATE_SIZE))