fix(ci): Remove hardcoded cloud_runner from maxtext_jupyter_notebooks#4355
Draft
mesakhcienet wants to merge 3 commits into
Draft
fix(ci): Remove hardcoded cloud_runner from maxtext_jupyter_notebooks#4355mesakhcienet wants to merge 3 commits into
mesakhcienet wants to merge 3 commits into
Conversation
a8b0d7b to
07b060e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
07b060e to
769e0a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two critical issues blocking the maxtext_jupyter_notebooks CI job from running successfully, particularly for Pull Requests originating from forks.
In commit f940dfd (April 29th), the notebook CI was updated to use v6e-8 and request a linux-x86-ct6e-180-8tpu runner to accommodate rl_llama3_demo.ipynb. However, because there are no 8-chip runners available in the CI pool, GitHub Actions queues the job indefinitely, blocking all PRs.
Due to GitHub Actions security restrictions, PRs originating from forks cannot access repository secrets. Consequently, ${{ secrets.HF_TOKEN }} evaluates to an empty string. This caused the hf auth login --token "$HF_TOKEN" command to crash with an Illegal header value b'Bearer ' exception.
workflow.
Motivation and Context
These fixes are necessary to restore a passing baseline for the MaxText CI pipeline. Currently, the notebook job either hangs forever (due to the missing runner) or crashes immediately (due to the empty token on fork PRs).
How has this been tested?
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.