fix: SG-44522: Update QSS of the new annotation tool - #1402
Open
eloisebrosseau wants to merge 24 commits into
Open
fix: SG-44522: Update QSS of the new annotation tool#1402eloisebrosseau wants to merge 24 commits into
eloisebrosseau wants to merge 24 commits into
Conversation
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
September 4, 2026 21:34
| t = (self._value - self._min) / max(1, self._max - self._min) | ||
| return int(bot - t * (bot - top)) | ||
| _HANDLE_LENGTH = 18 | ||
| _GROOVE_MARGIN = 3 |
Contributor
There was a problem hiding this comment.
Slider hit-test math doesn't match rendered geometry (annotate_beta_widget.py:155) — _GROOVE_MARGIN = 3 is hardcoded but the QSS sets margin: 0px. Drag position and value are off by ~6px total span, causing the handle to drift from the cursor and saturate early near the track ends.
Feel free to ignore if this is not signifcant to cause an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SG-44522: Update QSS of the new annotation tool
Summarize your change.
The majority of the changes are from all the QSS files. You don't need to review all of them since both template files are identical to each other, and that the only difference between them and the QSS files is the the variable names defined in
rv_theme_variable.confthat were replaced with actual RGB values. The legacy QSS files contain a subset of what is defined in the non-legacy ones.Rename colour to color in
annotate_beta_engine.pyandannotate_beta_widget.py. The only needed change was the tooltip name that should use the American spelling instead of the Canadian spelling based on the Figma design. However, to avoid having two spellings (which was also the case because Qt is also using the American spelling), I felt like it would be more consistent to rename everything instead of just the tooltip.Remove unnecessary svg files that were not actually needed.
Remove anything related to PySide2 in favor of PySide6 since there is no reason to support both anymore.
annotate_beta_widget.pywas updated to use the components defined in the QSS files. The file was also partially cleaned up to remove, modify or add methods based on the migration of the style sheets to QSS and the use of Qt's components as much as possible instead of custom ones. For instance, instead of using a custom slider, we are now using a QSlider, so a lot of functionality that was added to that custom widget was removed or updated to only the calculation of the handle position. For the same reason, the custom title bar was also replaced with a QDockWidget.Describe the reason for the change.
The new annotation tool had all the stylesheets define directly in the Python code instead of reusing or defining it's own properties in the application's QSS files. This is important to make sure the panel matches with the overall theme of the application that is customizable. Also, some parts of the UI could have been a little closer to the Figma design.
Describe what you have tested and on which operating system.
The whole tool bar was tested on both macOS and Rocky Linux 9 to make sure the functionalities are still behaving the way they should.
If possible, provide screenshots.
BEFORE
AFTER