ci: turn unity builds off when building OIIO for CI - #2143
Merged
Conversation
This fixes a break where OIIO has a declaration in exrinput.cpp that is mismatched if a unity build combines it with exrinput_c.cpp. I have a fix in progress on the OIIO side but this is the expedient workaround here -- just don't use unity build. When we are sure it's fixed on the OIIO side for any version we will build in CI, then we can go back to unity builds. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Merging without review because this is needed to unbreak CI (and changes no code so can't break any users). |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 2, 2026
…oundation#2143) This fixes a break where OIIO has a declaration in exrinput.cpp that is mismatched if a unity build combines it with exrinput_c.cpp. I have a fix in progress on the OIIO side but this is the expedient workaround here -- just don't use unity build. When we are sure it's fixed on the OIIO side for any version we will build in CI, then we can go back to unity builds. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a break where OIIO has a declaration in exrinput.cpp that is mismatched if a unity build combines it with exrinput_c.cpp. I have a fix in progress on the OIIO side but this is the expedient workaround here -- just don't use unity build. When we are sure it's fixed on the OIIO side for any version we will build in CI, then we can go back to unity builds.