fix(channels): raise doctor probe timeout 5s→15s (cold-TLS false ConnectTimeout)#65
Merged
Conversation
…lse ConnectTimeout The doctor auth probe used a 5s timeout, but a cold TLS handshake to a hosted WeChat gateway (e.g. *.wisdom.acedata.cloud) can take ~6-7s on the first connect. That made `channels doctor` report [FAIL] unreachable: ConnectTimeout even though `channels start` connects fine — a confusing false negative during first-time setup. Bump the probe timeout to 15s. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
channels doctorused a 5.0s httpx timeout for its authenticated probe(
GET /api/tasks/<probe>). A cold TLS handshake to a hosted WeChat gateway(
*.wisdom.acedata.cloud) takes ~6.6s on the first connect (measured), sodoctor reported
[FAIL] unreachable: ConnectTimeouteven though the gateway washealthy and
channels startconnected fine. That false negative sends userschasing a nonexistent connectivity problem during first-time setup.
Fix: raise the probe timeout 5.0 → 15.0s.
Evidence (live)
channels smokeandchannels startwere already succeeding against the samegateway; only
doctormis-reported.Scope
One-line timeout constant + comment. The existing doctor test monkeypatches
WeChatClient.__init__(…, *, timeout=…)and forwards the arg, so it isunaffected (no test asserts the literal
5.0).🤖 对抗评审
Reviewer: Codex (
codex exec --sandbox read-only, cross-model). Both thisdiff and the paired PlatformFrontend snippet fix were reviewed together for
correctness, wrong commands/env-var names, token leakage, and test breakage.
VERDICT: CLEAN — no findings.