CI: add --features cycle-driver to the supervisor step (30 unrun falsifiers, incl. the 64k headline) - #900
Merged
Conversation
…ifiers) `cycle-driver` is a SEPARATE feature that `supervisor` does not imply, so the supervisor step -- despite being this crate's own step -- never compiled `cycle_driver`, the three `probe_ignition*` / `d_ign_b_lenses` test binaries, or any of #879's loop-closure contract. Measured on this tree, not inferred: --features supervisor 13 tests --features supervisor,cycle-driver 43 tests, 0 failed The 30 in the gap include `probe_ignition_64k_start_at_full_population` -- the 65,536-owner / 17-sealed headline canonized as E-64K-1TO1-OWNERS-IS-THE-MAIN-MODEL-1. It runs in 13.75 s and passes; it had simply never run anywhere but a developer machine. #891 recorded this gap and deliberately did not touch the workflow. #898 closed the identical shape for callcenter (`--features query`) but not this one -- same arc, same defect class, one closed and one left open. One added feature closes it, and the new invocation is a strict superset of the old, so it cannot lose coverage.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe supervisor test workflow now enables the ChangesCI test coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7cbfa424-7671-421c-a27c-314fcab616f2) |
`ndarray` removed `blake3` as a dependency deliberately -- its Cargo.toml now carries "blake3 -- NO LONGER A DEPENDENCY. Do not re-add it.", with BLAKE3 moved in-tree to `src/hpc/blake3.rs` to break a `ndarray -> blake3 -> ndarray` cycle and to shed blake3's unconditional `cc` build-dependency. lance-graph's lockfile never caught up and still listed it. Cargo corrected it on its own during the supervisor test runs for the cycle-driver CI step; this commit just records that correction rather than leaving the tree dirty. Verified this reflects ndarray's DEFAULT branch (master @ 417f66a3), not the in-flight ndarray branch this session is also pushing -- a lock refresh that pinned lance-graph to an unmerged sibling state would be the wrong thing to commit, so that was checked before landing it.
AdaWorldAPI
marked this pull request as ready for review
August 5, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap #891 recorded and #898 didn't close
cycle-driveris a separate feature thatsupervisordoes not imply. Sothe supervisor CI step — despite being this crate's own step — never compiled
cycle_driver, the threeprobe_ignition*/d_ign_b_lensestest binaries, orany of #879's loop-closure contract.
Measured on this tree, not inferred:
--features supervisor(today)--features supervisor,cycle-driverThe 30 in the gap include
probe_ignition_64k_start_at_full_population—the 65,536-owner / 17-sealed headline canonized as
E-64K-1TO1-OWNERS-IS-THE-MAIN-MODEL-1. It runs in 13.75 s and passes. It hadsimply never run anywhere but a developer machine.
Why this one and not the other
#891 recorded this gap and deliberately left the workflow alone (correctly — it
was scoped elsewhere). #898 then closed the identical shape for callcenter
(
--features query). Same arc, same defect class, one closed and one not.Grepping
.github/workflows/forcycle-driverreturned zero matches beforethis PR.
Safety of the change
One added feature on an existing step. The new invocation is a strict
superset of the old one, so it cannot lose coverage, and it was run locally
first — 43 passed, 0 failed — so it does not land red.
No new job, no new checkout, no extra cold compile: the step already builds this
crate.
Also in this PR: one stale lockfile line
Cargo.locklistedblake3underndarray's dependencies. ndarray removed itdeliberately — its manifest now says "blake3 — NO LONGER A DEPENDENCY. Do not
re-add it.", with BLAKE3 moved in-tree to break an
ndarray → blake3 → ndarraycycle and drop blake3's unconditional
ccbuild-dep. lance-graph's lock nevercaught up; cargo corrected it during the supervisor test runs for this change.
Checked before committing that this reflects ndarray's default branch
(
master@ 417f66a3) and not the in-flight ndarray branch this session is alsopushing — a lock refresh pinned to an unmerged sibling would be the wrong thing
to land.
Summary by CodeRabbit