[balanceplatform] Code generation: update services and models

[AdyenAutomationBot]

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

[gemini-code-assist]

Code Review

This pull request introduces support for recurring top-ups in the balance platform SDK, adding several new DTO models, updating transaction rules with a bypass option, and implementing the RecurringTopUpsApi service. It also adds a delete endpoint to the SCA device management API. Feedback on these changes highlights opportunities to improve efficiency by avoiding unnecessary boxing of primitive booleans in AmountDTO, enhancing robustness with null checks on request bodies in RecurringTopUpsApi, and restoring type safety by using String instead of Object for the beneficiary reference in PatchableCreateRecurringTopUp.

[gemini-code-assist]

Using Objects.equals on primitive boolean fields like isSetCurrency and isSetValue causes unnecessary boxing to Boolean objects. For primitive fields, direct comparison using == is more efficient and idiomatic in Java.

    return Objects.equals(this.currency, amountDTO.currency)
        && this.isSetCurrency == amountDTO.isSetCurrency
        && Objects.equals(this.value, amountDTO.value)
        && this.isSetValue == amountDTO.isSetValue;

[gemini-code-assist]

If createRecurringTopUp is null, calling createRecurringTopUp.toJson() will throw a NullPointerException. It is safer to perform a null check and throw an IllegalArgumentException, similar to the path parameter check.

Suggested change

	if (balanceAccountId == null) {
	throw new IllegalArgumentException("Please provide the balanceAccountId path parameter");
	}
	pathParams.put("balanceAccountId", balanceAccountId);
	String requestBody = createRecurringTopUp.toJson();
	if (balanceAccountId == null) {
	throw new IllegalArgumentException("Please provide the balanceAccountId path parameter");
	}
	pathParams.put("balanceAccountId", balanceAccountId);
	if (createRecurringTopUp == null) {
	throw new IllegalArgumentException("Please provide the createRecurringTopUp request body");
	}
	String requestBody = createRecurringTopUp.toJson();

[gemini-code-assist]

If patchableCreateRecurringTopUp is null, calling patchableCreateRecurringTopUp.toJson() will throw a NullPointerException. It is safer to perform a null check and throw an IllegalArgumentException.

    if (balanceAccountId == null) {
      throw new IllegalArgumentException("Please provide the balanceAccountId path parameter");
    }
    pathParams.put("balanceAccountId", balanceAccountId);
    if (topUpId == null) {
      throw new IllegalArgumentException("Please provide the topUpId path parameter");
    }
    pathParams.put("topUpId", topUpId);
    if (patchableCreateRecurringTopUp == null) {
      throw new IllegalArgumentException("Please provide the patchableCreateRecurringTopUp request body");
    }

    String requestBody = patchableCreateRecurringTopUp.toJson();

[gemini-code-assist]

The field referenceForBeneficiary is defined as Object here, whereas in CreateRecurringTopUp and RecurringTopUp it is defined as String. Using Object loses type safety and forces users to cast or pass arbitrary objects. If this is due to nullability in the OpenAPI spec, consider configuring the generator to map nullable strings to String instead of Object.

[sonarqubecloud]

Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jeandersonbc]

This naming doesn't follow our conventions and must be fixed at the spec. Marking this as do-not-merge for now.