Add tests for BalancePlatformWebhooksTest#2018
Open
poojah-adyen wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several unit tests to BalancePlatformWebhooksTest to verify the deserialization behavior of various webhook payloads, including mandate notifications with invalid dates, unknown account identification types, payment instruments with IBAN additional bank account identifications, and top-up configuration events (created, updated, and unknown types). It also introduces the corresponding mock JSON files for these tests. There are no review comments, and I have no feedback to provide.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit test coverage for the Configuration Webhooks functionality introduced by the latest OpenAPI (Configuration Webhooks v2) model update — specifically the new recurring top-up webhooks (balancePlatform.balanceAccount.recurringTopUp.created and .updated) plus the Mandate.createdAt/updatedAt type change from Object to OffsetDateTime. It also strengthens coverage of the MandateBankAccountAccountIdentification and
PaymentInstrumentAdditionalBankAccountIdentificationsInner oneOf discriminator deserialization (ukLocal and iban mappings) by adding failure-path tests for invalid dates and unknown discriminator types. Mock payloads for the new webhooks are sourced directly from the official OpenAPI spec examples.
Tested scenarios
Fixed issue: