fix(agno): clean up async streams on iteration errors - #1431
Open
KXHXK wants to merge 1 commit into
Open
Conversation
KXHXK
marked this pull request as ready for review
July 26, 2026 10:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ERROR, record the original exception, end the span, and remove its stored context exactly onceWithout this cleanup, failed async Agent/Team streams leave an unended span and a stale entry in
StreamingContextManager.Closes #1430
Testing
uv run ruff check agentops/instrumentation/agentic/agno/instrumentor.py tests/unit/instrumentation/test_agno_instrumentor.pyuv run ruff format --check agentops/instrumentation/agentic/agno/instrumentor.py tests/unit/instrumentation/test_agno_instrumentor.pyuvx pre-commit run --files agentops/instrumentation/agentic/agno/instrumentor.py tests/unit/instrumentation/test_agno_instrumentor.pyPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --no-sync pytest -p pytest_asyncio.plugin -p pytest_mock tests/unit/instrumentation -q(139 passed)