fix: preserve stream error status - #1435
Open
KXHXK wants to merge 1 commit into
Open
Conversation
KXHXK
marked this pull request as ready for review
July 26, 2026 10:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1434.
The common synchronous and asynchronous stream wrappers currently mark a span as
ERRORwhen iteration raises, then overwrite that status withOKduring finalization. This change keeps final attribute collection and span closure intact while skipping the success status after an iteration failure.Both wrapper variants now have regression coverage asserting that the emitted status remains
ERROR.Testing
tests/unit/instrumentation/common: 56 passedruff check: passedruff format --check: passedgit diff --check: passedDirect
mypy agentops/instrumentation/common/streaming.pyreports the pre-existing unannotatedaccumulated_contentlist on line 36; the same line is present onupstream/mainand is outside this patch.