Skip to content

chore: wire the apps to the extracted packages, and put /m's reverse bounce behind AGENTA_MOBILE_REVERSE_GATE - #5881

Draft
ardaerzin wants to merge 1 commit into
pkg/home-uifrom
oss/wire-up
Draft

chore: wire the apps to the extracted packages, and put /m's reverse bounce behind AGENTA_MOBILE_REVERSE_GATE#5881
ardaerzin wants to merge 1 commit into
pkg/home-uifrom
oss/wire-up

Conversation

@ardaerzin

Copy link
Copy Markdown
Contributor

The bookkeeping lane for everything below it: OSS and EE now import from the extracted packages,
and /m's reverse bounce to the desktop app sits behind AGENTA_MOBILE_REVERSE_GATE rather than
being unconditional.
Not run in a browser — static gates only (pnpm lint-fix 24/24, tsc --noEmit clean
for @agenta/shared, ui, entities, entity-ui, settings-ui, oss, ee, mobile).

Stacked on pkg/home-ui; review only this lane's diff.

@ardaerzin

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Error Error Aug 11, 2026 5:10am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b52ebbd-4291-4ef0-a7ae-6e60290680f5

📥 Commits

Reviewing files that changed from the base of the PR and between aba75d6 and d7f741d.

⛔ Files ignored due to path filters (1)
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (17)
  • docs/design/agenta-mobile/README.md
  • hosting/docker-compose/ee/docker-compose.dev.yml
  • hosting/docker-compose/ee/docker-compose.gh.yml
  • hosting/docker-compose/ee/env.ee.dev.example
  • hosting/docker-compose/oss/docker-compose.dev.yml
  • hosting/docker-compose/oss/docker-compose.gh.yml
  • hosting/docker-compose/oss/env.oss.dev.example
  • web/oss/package.json
  • web/oss/src/lib/helpers/auth/AuthProvider.tsx
  • web/packages/agenta-shared/src/api/axios.ts
  • web/packages/agenta-shared/src/api/index.ts
  • web/packages/agenta-shared/src/utils/mobileGate/index.ts
  • web/packages/agenta-shared/tests/unit/mobileGate.test.ts
  • web/packages/agenta-ui/src/RichChatInput/RichChatInput.tsx
  • web/packages/agenta-ui/src/components/presentational/attachments/ImagePreview.tsx
  • web/packages/agenta-ui/src/components/presentational/index.ts
  • web/packages/agenta-ui/src/components/ui/split-pane.tsx

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added configurable reverse mobile routing, allowing mobile views to be tested on tablet and desktop devices.
    • Added shared authentication-token support for API requests.
    • Exposed the filter rail layout for broader UI use.
  • Bug Fixes

    • Improved rich-text placeholder sizing, wrapping, and alignment.
    • Fixed split-pane resizing when content has a wide minimum width.
    • Updated image preview overlay styling for consistent rendering.
  • Documentation

    • Documented reverse mobile routing configuration and development setup options.
  • Tests

    • Added coverage for reverse mobile routing behavior and opt-in redirects.

Walkthrough

The PR adds configurable reverse mobile-gate behavior, shared JWT access for raw fetches, Compose environment wiring, and documentation. It also updates several UI layouts, exports, and styling rules.

Changes

Mobile routing and authentication

Layer / File(s) Summary
Reverse mobile-gate behavior
web/packages/agenta-shared/src/utils/mobileGate/index.ts, web/packages/agenta-shared/tests/unit/mobileGate.test.ts
reverseGateEnabled: false allows desktop requests through while preserving mobile redirects and mobile opt-in handling.
Shared authentication-token wiring
web/packages/agenta-shared/src/api/axios.ts, web/packages/agenta-shared/src/api/index.ts, web/oss/src/lib/helpers/auth/AuthProvider.tsx, web/oss/package.json
The API exposes asynchronous token registration and retrieval. AuthProvider registers the current JWT provider.
Mobile-gate deployment configuration
hosting/docker-compose/{ee,oss}/*, docs/design/agenta-mobile/README.md
OSS and EE environments configure AGENTA_MOBILE_REVERSE_GATE, with defaults and behavior documented.

UI adjustments

Layer / File(s) Summary
UI layout and component exports
web/packages/agenta-ui/src/RichChatInput/RichChatInput.tsx, web/packages/agenta-ui/src/components/presentational/attachments/ImagePreview.tsx, web/packages/agenta-ui/src/components/presentational/index.ts, web/packages/agenta-ui/src/components/ui/split-pane.tsx
The changes adjust placeholder layout, opacity classes, presentational exports, and split-pane shrinking behavior.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant decideMobileGate
  participant DeviceDetection
  Browser->>decideMobileGate: request with user agent and gate options
  decideMobileGate->>DeviceDetection: inspect device type
  DeviceDetection-->>decideMobileGate: device classification
  decideMobileGate-->>Browser: pass request or redirect to /m
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both main changes: wiring applications to extracted packages and gating the /m reverse redirect.
Description check ✅ Passed The description accurately explains the package wiring, reverse gate behavior, validation results, and review scope.
Docstring Coverage ✅ Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 60.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch oss/wire-up

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ardaerzin

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ardaerzin

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant