refactor(frontend): SchemaForm and SubscriptionForm off antd Form - #5891
Draft
ardaerzin wants to merge 1 commit into
Draft
refactor(frontend): SchemaForm and SubscriptionForm off antd Form#5891ardaerzin wants to merge 1 commit into
ardaerzin wants to merge 1 commit into
Conversation
Contributor
Author
|
@coderabbitai review |
Rate Limit Exceeded
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR adds an ChangesGateway form migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ardaerzin
force-pushed
the
pkg/settings-tools-triggers
branch
from
August 10, 2026 14:59
c1ee3bc to
7048eae
Compare
ardaerzin
force-pushed
the
pkg/entity-ui-form-engine
branch
from
August 10, 2026 14:59
1880f06 to
e593c54
Compare
ardaerzin
force-pushed
the
pkg/settings-tools-triggers
branch
from
August 10, 2026 15:14
7048eae to
f8a5737
Compare
ardaerzin
force-pushed
the
pkg/entity-ui-form-engine
branch
from
August 10, 2026 15:14
e593c54 to
034448b
Compare
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
antd's Form IS @rc-component/form — antd wraps it and adds the label/error chrome and its theming. So this is a swap of the wrapper, not a rewrite of the engine: name paths, rules, initialValue, valuePropName, validateFields, Form.List and useWatch all keep working because it is the same implementation underneath. The chrome comes back as FormItem, a small shim over rc's Field that draws label and error with @agenta/ui's Field. That component carries no antd and needs no ConfigProvider, which is the whole point: these forms can now render on a host that forbids antd instead of falling back to antd's light theme. `form: FormInstance` stays cross-package public API. antd's instance is structurally rc's, so web/oss ElicitationWidget keeps driving it unchanged — tsc confirms across oss, ee and mobile. antd's List handed each row a fieldKey/isListField pair that only its Form.Item consumed; rc's Field needs neither, so that passthrough is gone. Neither gateway tree imports antd now, which unblocks turning off `readOnly` for Tools and Triggers on /m — not done here, since the drawers deserve a real look in a browser first. Gates: lint 24/24, tsc 0 across entity-ui, settings-ui, oss, ee and mobile.
ardaerzin
force-pushed
the
pkg/settings-tools-triggers
branch
from
August 11, 2026 05:11
f8a5737 to
d557bed
Compare
ardaerzin
force-pushed
the
pkg/entity-ui-form-engine
branch
from
August 11, 2026 05:11
034448b to
4832ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SchemaFormandSubscriptionFormmove from antd'sFormonto@rc-component/form— the sameengine antd itself uses, without the antd component layer. That is what makes the Tools and
Triggers drawers renderable on
/m, which the lane two above depends on.Read this one carefully.
SchemaFormis the form the chat runtime drives for elicitation, andnothing in this stack has been run in a browser. Five files, but the blast radius is the
elicitation path.
Not run in a browser — static gates only (
pnpm lint-fix24/24,tsc --noEmitcleanfor
@agenta/shared,ui,entities,entity-ui,settings-ui,oss,ee,mobile).Stacked on
pkg/settings-tools-triggers; review only this lane's diff.