fix(tests): select a registry row explicitly when none auto-selects - #5914
Merged
Conversation
The readiness wait added for the drawer-race review finding assumed the registry auto-selects a row; CI's fresh project never checks a checkbox, so the wait timed out (gate run 31401605372). Keep the race protection but create the selection when it is absent.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
Bot
added
size:XS
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Playwright helper now explicitly selects the first variant row before opening the API drawer. Five acceptance tests are now skipped with comments that document runtime or environment-sensitive CI issues. ChangesPlaywright acceptance test stabilization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…se-gate decision) Per Mahmoud, 2026-08-10: the acceptance gate's remaining red is a rotating tail of environment-sensitive tests (a different set each run) plus two tests whose 7-minute budgets and retries dominate the wall clock. Skip them with tracking comments rather than let them define the gate; each stays in the file for repair.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 06d547a0-e0ea-4fdd-bf4c-6f0aae39ad17
📒 Files selected for processing (1)
web/oss/tests/playwright/acceptance/use-api/index.ts
Contributor
Railway Preview Environment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The readiness wait added in #5905's review round (wait for a checked row before opening the Use API drawer) assumed the registry auto-selects a row. CI's fresh project never checks one, so both use-api tests fail on the wait itself (gate run). My regression, honestly labeled.
Changes
Keep the race protection (the drawer captures the revision at click time), but when no row is checked, click the first row's checkbox to create the selection, then require it. Works in both auto-selecting and non-selecting environments.
Tests
Prettier clean. CI on this PR validates both use-api tests in the exact environment that failed.
Update (release-gate decision)
Per the release-gate call, this PR now also skips five tests with tracking comments, none deleted:
The gate's meaning after this PR: the acceptance suite's passing set is deterministic; the skipped five are tracked repair backlog, visible as skips rather than masquerading as gate noise.