Skip to content

[fix] Mobile typecheck: import the AgentaApi type namespace - #5938

Merged
mmabrouk merged 1 commit into
release/v0.112.0from
fix/mobile-typecheck-agentaapi-import
Aug 11, 2026
Merged

[fix] Mobile typecheck: import the AgentaApi type namespace#5938
mmabrouk merged 1 commit into
release/v0.112.0from
fix/mobile-typecheck-agentaapi-import

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

The release branch's "check mobile" workflow fails on web/packages/agenta-entities/src/session/api/api.ts: it references AgentaApi.SessionInteractionResolution without importing the namespace (TS2503). The line landed in #5919; the web typechecks resolve the namespace ambiently, the mobile project graph does not, and the branch-level mobile workflow first completed a run only after today's merge train (earlier runs were superseded by rapid merges).

Fix: one type-only import, import type {AgentaApi} from "@agentaai/api-client", matching the existing precedent in trace/api/request.ts.

Verified: pnpm run types:check passes in @agenta/entities and @agenta/mobile.

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Blocked Blocked Aug 11, 2026 11:58am

Request Review

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. typescript Pull requests that update typescript code labels Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9f2a4483-f807-4805-ac8f-e34b7e86a020

📥 Commits

Reviewing files that changed from the base of the PR and between 7e1342d and 84846bf.

📒 Files selected for processing (1)
  • web/packages/agenta-entities/src/session/api/api.ts

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated internal session API typing support without changing user-facing functionality.

Walkthrough

The session API module adds a type-only AgentaApi import for an interaction resolution type assertion.

Changes

Session API typing

Layer / File(s) Summary
Add AgentaApi type import
web/packages/agenta-entities/src/session/api/api.ts
The module adds a type-only AgentaApi import for the interaction resolution type assertion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the change fixes mobile typechecking by importing the AgentaApi type namespace.
Description check ✅ Passed The description directly explains the mobile typecheck failure, the type-only import fix, and the verification results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mobile-typecheck-agentaapi-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-08-11T12:17:54.233Z

@mmabrouk
mmabrouk merged commit 51a7f91 into release/v0.112.0 Aug 11, 2026
66 of 68 checks passed
@mmabrouk
mmabrouk deleted the fix/mobile-typecheck-agentaapi-import branch August 11, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. typescript Pull requests that update typescript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant