chore(frontend): palette cleanup: hex migration, chart tokens, chip outlines, dark repairs - #5973
Merged
Merged
Conversation
…outline reference chips - Hex-to-palette migration: agent-accent chip deduped onto --ag-type-agent-* (6 files), #ff4d4f/#52c41a/#faad14 onto antd semantic tokens, dead var() fallbacks stripped (34 across 11 files) - chartSeries + chart chrome roles in palette.ts, emitted as --ag-chart-*; chartPalette.ts derives from the palette - runStatus role consolidates the status-dot table duplicated across three files (byte-identical both themes) - Reference chips regain a subtle outline (slot text colour at low alpha) - junit.xml removed from tracking and ignored
- 31 sites on undefined --ag-c-97A4B0 (fallback was painting pre-recolor navy grey in both themes) -> --ag-zinc-5; 4 sites on undefined --ag-c-D6DEE6 -> --ag-zinc-3 - 6 drill-in header links from raw Tailwind blue / #58a6ff -> --ag-btn-link (makes palette.ts's absorb claim true) - 5 foreground #1c2c3d navy sites (invisible on dark) -> colorText; layout banner bg -> colorBgSpotlight (brand alignment, separately vetoable) - #BDC7D1 folder glyphs -> colorTextQuaternary; EnvironmentStatus dots -> --ag-env-*-text Per-line before/after table in the PR description; generator run was a pure no-op (only existing roles consumed)
dosubot
Bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (51)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR centralizes interface colors in theme palettes and CSS variables. It updates charts, status indicators, icons, controls, editors, and drill-in components. It also removes obsolete palette exports, removes CSS fallbacks, and ignores generated JUnit reports. ChangesTheme Token Migration
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Railway Preview Environment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Post-merge cleanup round for the recolor sprint, as agreed in the #5943 review: move raw hex to the palette system, tokenize the charts, restore reference-chip outlines, and repair the places dark mode was demonstrably broken.
Changes
Hex-to-palette migration (435 hex-bearing lines at the sprint's start, 136 now, survivors documented below)
--ag-type-agent-bg/-text.#ff4d4f/#52c41a/#faad14moved to antd semantic tokens (see veto table 1).#hexfallbacks stripped fromvar(--ag-c-*, #hex)across 11 files (each token verified defined in both themes first).runStatuspalette role replaces the status-dot table that was byte-identical in three files (theme-blind by design: zero rendered change).Chart tokenization
palette.tsnow ownschartSeries(5 ordered light/dark pairs) and chart chrome roles (grid/axis/reference/track), emitted as--ag-chart-*.chartPalette.tsderives from the palette instead of holding literals; chart components consume the CSS variables directly.Reference-chip outlines (review follow-up from #5943)
referenceTaguses a newoutlinedTagTone(): border = the slot's own text color at 0.22 alpha light / 0.30 dark. FlatenvironmentTag/presetTagunchanged.Dark-mode repairs (founder-approved exception to the dark freeze: fix only what is demonstrably broken)
--ag-c-97A4B0, which was never emitted anywhere, so their hardcoded pre-recolor fallback was painting in BOTH themes. Now--ag-zinc-5per the palette's own alias table. 4 more sites on undefined--ag-c-D6DEE6→--ag-zinc-3.#58a6ff(dark) →--ag-btn-link. This makes palette.ts's existing "absorbs the 6× #58a6ff literal" comment true for the first time.#1c2c3d(invisible on the dark surface: Prompts-page icons, observability progress fill, deployment-card border, eval swatch) →colorText.#BDC7D1folder glyphs →colorTextQuaternary;EnvironmentStatusdots →--ag-env-*-text(matches the approved environment tag tones).junit.xmluntracked and ignored; deadeditorChippalette family deleted (generated nowhere, imported by nobody).Veto table 1 — seed-token dark shifts (each is a one-line revert)
antd derives dark values for colorError/Success/Warning from the seed, so these three migrations shift dark slightly:
#ff4d4f→colorError#ff4d4f→#dc4446#52c41a→colorSuccess#52c41a→#49aa19#faad14→colorWarning#faad14→#d89614Veto table 2 — dark repairs (rendered values, read live)
--ag-c-97A4B0(DrillIn/SchemaControls cluster)#97a4b0|#97a4b0#a3a19f|#5c5c5c#D6DEE6(SkillUploadZone, CustomAppCreationLoader)#d6dee6|#d6dee6#e5e5e3|#383838#2563eb|#58a6ff#5e5e08|#8ccfff#1c2c3d|#1c2c3d#242424|rgba(255,255,255,0.85)#1c2c3d|#1c2c3drgba(36,36,36,0.9)|#424242(white text stays legible in both)#bdc7d1|#bdc7d1#a3a19f|rgba(255,255,255,0.25)#73D13D/#FF7A45/#9254DEboth themesVerification
--ag-chart-*/--ag-run-status-*additions; no other pre-existing value changed in either theme. The final dark-repair round was a pure generator no-op (only existing roles consumed).tsc --noEmitclean (oss + touched packages), prettier/eslint clean, dev stack healthy throughout.Deliberately left (documented for the next round)
#f0f0f0/#d9d9d9) are the only grids VISIBLE in dark, so converging them blindly would regress dark. Needs one intentional grid-strength decision per theme.--ag-c-*shim crosses roles between themes (--ag-c-EAEFF5= border in light but elevated surface in dark), so remaining shim sites need per-site human decisions; there is no safe find-and-replace.