test(runner): platform-guidance tests learn the always-on file-citation sentence

[mmabrouk]

What

Fixes the red run-runner-tests check on the release PR #5988. Test-only change; no runtime code is touched.

Why

#6009 added the file-citation sentence to platformGuidanceAppendix deliberately without a tool gate (any run can mention a file in chat, and the client now resolves absolute paths). Five older tests in platform-guidance.test.ts still used "the whole appendix is undefined" as a proxy for "the config sentences are gated on commit_revision", and the two character-budget ceilings predate the third sentence.

How

• The three tool-gate tests now assert the absence of the config sentences (parameters.agent.skills, agents_md) and the presence of the file-citation sentence, instead of an empty block.
• The always-on budget rises 900 → 1200 and the codex budget 1200 → 1450, each with a comment carrying the new sentence's numbers and the observed failures it answers ([bug] File links in chat open the wrong file #6004, (feat) Open agent-mentioned files in the side pane #5983), matching the file's own rule that a new sentence needs its own numbers.

Verification

Full runner unit suite: 2146/2146 passing, 126 files. tsc --noEmit clean.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agenta-documentation	Error		Aug 13, 2026 4:00pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d9104ef-4dda-4e1f-bb3d-9435af4d9686

📥 Commits

Reviewing files that changed from the base of the PR and between 58d1fbc and c397172.

📒 Files selected for processing (1)

• services/runner/tests/unit/platform-guidance.test.ts

---

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Expanded automated coverage for file-citation guidance and its interaction with tool availability.
  • Increased validation limits for always-available and Codex-specific guidance.
  • Confirmed that relevant file-citation guidance remains available without configuration, while skill and instruction guidance stays appropriately restricted.
  • Added checks to ensure commit-related guidance appears only when the required capability is available and unrelated guidance remains accessible.

Walkthrough

The pull request updates platform-guidance unit tests. The tests cover file-citation guidance, revised length ceilings, and conditional skill and instruction sentences based on available tools.

Changes

Platform guidance test coverage

Layer / File(s)	Summary
Guidance content and tool-gating assertions services/runner/tests/unit/platform-guidance.test.ts	The tests import fileCitationAppendix, increase guidance length ceilings, require file-citation guidance without commit_revision, and verify tool-dependent sentences for commit_revision and read_config availability.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to c3971

This test-only change updates platform-guidance expectations and character budgets for the always-on file-citation sentence; it does not alter runtime behavior, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test update for the always-on file-citation sentence.
Description check	✅ Passed	The description directly explains the test-only changes, their purpose, and verification results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/rel112-platform-guidance-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Railway Preview Environment

Status	Destroyed (PR closed)

Updated at 2026-08-13T18:13:22.321Z