docs(docs): preserve quoted values when loading test env files - #6693
docs(docs): preserve quoted values when loading test env files#6693jabrailkhalil wants to merge 2 commits into
Conversation
|
@jabrailkhalil is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe testing guide now explains that exported ChangesTesting documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The testing guide update documents environment-file usage and variable precedence without any identified remaining merge-readiness risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Advanced
Run ID: babcec14-27e2-4e7c-acdb-e81a89413f27
📒 Files selected for processing (1)
docs/docs/contributing/guides/testing.mdx
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Summary
The testing guide's
export $(... | xargs)fallback splits quoted environment values. For example,AGENTA_AUTH_KEY="synthetic key with spaces"becomes justsynthetic. The guide now uses the Python runners' existing--env-fileoption, with the correct relative paths for API, services, and SDK contributors.Testing
Verified locally
npm run buildindocs/: passed with Node 22.21.1 and dependencies installed using pinned pnpm 10.30.0. Existing redirect/deprecation warnings remain.git diff --check: passed.Added or updated tests
No permanent tests added for this documentation-only correction.
QA follow-up
No live application stack or production credentials were used.
Demo
N/A: documentation-only command correction, no UI behavior change.
Checklist
Contributor Resources
Contributing guide