[fix] Give the skill registry ops a build-kit permission so skills load again - #6744
Conversation
…s and agents load again DEFAULT_BUILD_KIT_OPS gained search_skills, check_skill_updates and apply_skill_update with the skill registry, but _BUILD_KIT_OP_PERMISSIONS never learned them. Every build of the agent-template overlay raised KeyError: 'search_skills', so the skills query, the skills page and the agent catalog answered 500 on release/v0.116.0. The two reads allow; the apply asks, because its approval card is the user prompt. The overlay test's expected map gains the same three entries; it was red for the same reason. Claude-Session: https://claude.ai/code/session_01AY886ajXX65KAa1Vc9JCXU
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Mahmoud Mabrouk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe build kit now assigns permissions to three skill operations. Unit test expectations match the new values: ChangesBuild Kit skill permissions
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This restores Skills and agent catalog functionality while preserving approval for skill updates. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
Updated at 2026-09-10T11:19:03.453Z |
Context
On
release/v0.116.0the Skills page,POST /api/skills/query, and the agent catalog answer 500 withoperation_id: query_registry_skills. The API log showsKeyError: 'search_skills'frombuild_agent_template_overlay. The skill registry addedsearch_skills,check_skill_updates, andapply_skill_updatetoDEFAULT_BUILD_KIT_OPS, and the later permissions change added_BUILD_KIT_OP_PERMISSIONSwithout them. Every overlay build looks up a permission for each op, so the first missing one raises. Found while doing QA for #6743 on a stack built from the release branch.Changes
The permission map gains the three ops. The two reads allow. The apply asks, because it is a write and its approval card is the user prompt, which is what the comment above the op list already says.
Before:
After:
The overlay unit test's expected permission map gains the same three entries. It was red on the release branch for the same reason.
Tests
api/oss/tests/pytest/unit/applications/test_build_kit_overlay.pyandapi/oss/tests/pytest/unit/workflows/test_static_catalog.py: 51 passed. Before the change, 7 of 8 overlay tests failed with the same KeyError.ruff formatandruff checkon both files: clean.What to QA
https://claude.ai/code/session_01AY886ajXX65KAa1Vc9JCXU