Skip recording DNS noise for private IP literals with no pending port#325
Open
Mishenevd wants to merge 3 commits into
Open
Skip recording DNS noise for private IP literals with no pending port#325Mishenevd wants to merge 3 commits into
Mishenevd wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Mishenevd
force-pushed
the
fix/dns-noise-private-ip-only
branch
from
July 23, 2026 12:21
758e215 to
608a268
Compare
Private IP literal hostnames with no pending port (resolver bootstrap noise, network capability probing, etc.) flood the outbound-connections dashboard. Outbound domain blocking and SSRF detection stay fully unconditional either way - only the dashboard hit is skipped.
Mishenevd
force-pushed
the
fix/dns-noise-private-ip-only
branch
from
July 23, 2026 12:23
608a268 to
39d0c25
Compare
hansott
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal, smaller version of #317 — skips dashboard noise from private-IP-literal DNS lookups with no pending port, everything else (outbound blocking, SSRF checks, port-based recording) stays unconditional and unchanged.
Summary by Aikido
⚡ Enhancements
📚 Documentation
More info