Skip to content

Change division to use float for massInv #15693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Aug 20, 2026
+8 −8
Merged

Change division to use float for massInv #15693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,12 +1364,12 @@ GPUd() bool TrackParametrizationWithError<value_T>::correctForMaterial(value_t x
}
auto m = this->getPID().getMass();
int charge2 = this->getAbsCharge() * this->getAbsCharge();
value_t p = this->getP(), p0 = p, p02 = p * p, e2 = p02 + this->getPID().getMass2(), massInv = 1. / m, bg = p * massInv, dETot = 0.;
value_t p = this->getP(), p0 = p, p02 = p * p, e2 = p02 + this->getPID().getMass2(), massInv = 1.f / m, bg = p * massInv, dETot = 0.f;
value_t e = gpu::CAMath::Sqrt(e2), e0 = e;
if (m > 0 && xrho != 0.f) {
value_t ekin = e - m, dedx = this->getdEdxBBOpt(bg);
#ifdef _BB_NONCONST_CORR_
value_t dedxDer = 0., dedx1 = dedx;
value_t dedxDer = 0.f, dedx1 = dedx;
#endif
if (charge2 != 1) {
dedx *= charge2;
Expand All @@ -1391,11 +1391,11 @@ GPUd() bool TrackParametrizationWithError<value_T>::correctForMaterial(value_t x
}
while (na--) {
#ifdef _BB_NONCONST_CORR_
if (dedxDer != 0.) { // correction for non-constantness of dedx vs beta*gamma (in linear approximation): for a single step dE -> dE * [(exp(dedxDer) - 1)/dedxDer]
if (dedxDer != 0.f) { // correction for non-constantness of dedx vs beta*gamma (in linear approximation): for a single step dE -> dE * [(exp(dedxDer) - 1)/dedxDer]
if (xrho < 0) {
dedxDer = -dedxDer; // E.loss ( -> positive derivative)
}
auto corrC = (gpu::CAMath::Exp(dedxDer) - 1.) / dedxDer;
auto corrC = (gpu::CAMath::Exp(dedxDer) - 1.f) / dedxDer;
dE *= corrC;
}
#endif
Expand Down Expand Up @@ -1499,12 +1499,12 @@ GPUd() bool TrackParametrizationWithError<value_T>::correctForMaterial(TrackPara
auto pid = linRef.getPID();
auto m = pid.getMass();
int charge2 = linRef.getAbsCharge() * linRef.getAbsCharge();
value_t p = linRef.getP(), p0 = p, p02 = p * p, e2 = p02 + pid.getMass2(), massInv = 1. / m, bg = p * massInv, dETot = 0.;
value_t p = linRef.getP(), p0 = p, p02 = p * p, e2 = p02 + pid.getMass2(), massInv = 1.f / m, bg = p * massInv, dETot = 0.f;
value_t e = gpu::CAMath::Sqrt(e2), e0 = e;
if (m > 0 && xrho != 0.f) {
value_t ekin = e - m, dedx = this->getdEdxBBOpt(bg);
#ifdef _BB_NONCONST_CORR_
value_t dedxDer = 0., dedx1 = dedx;
value_t dedxDer = 0.f, dedx1 = dedx;
#endif
if (charge2 != 1) {
dedx *= charge2;
Expand All @@ -1526,11 +1526,11 @@ GPUd() bool TrackParametrizationWithError<value_T>::correctForMaterial(TrackPara
}
while (na--) {
#ifdef _BB_NONCONST_CORR_
if (dedxDer != 0.) { // correction for non-constantness of dedx vs beta*gamma (in linear approximation): for a single step dE -> dE * [(exp(dedxDer) - 1)/dedxDer]
if (dedxDer != 0.f) { // correction for non-constantness of dedx vs beta*gamma (in linear approximation): for a single step dE -> dE * [(exp(dedxDer) - 1)/dedxDer]
if (xrho < 0) {
dedxDer = -dedxDer; // E.loss ( -> positive derivative)
}
auto corrC = (gpu::CAMath::Exp(dedxDer) - 1.) / dedxDer;
auto corrC = (gpu::CAMath::Exp(dedxDer) - 1.f) / dedxDer;
dE *= corrC;
}
#endif
Expand Down
Loading