[ALICE3] Adapt input file handling to new ACTS input format - #17370
Open
lhusova wants to merge 1 commit into
Open
[ALICE3] Adapt input file handling to new ACTS input format#17370lhusova wants to merge 1 commit into
lhusova wants to merge 1 commit into
Conversation
github-actions
Bot
changed the title
|
O2 linter results: ❌ 27 errors, |
njacazio
marked this pull request as ready for review
August 18, 2026 10:36
njacazio
requested review from
alibuild,
hscheid,
jesgum and
njacazio
as code owners
August 18, 2026 10:36
Collaborator
|
Error while checking build/O2Physics/staging for c7268d8 at 2026-08-18 12:49: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for c7268d8 at 2026-08-18 12:51: Full log here. |
jesgum
reviewed
Aug 18, 2026
| void addMCParticle(int collIndex, ParticleStruct& fileParticles, int iParticle, uint8_t flags, int firstMother, int firstDaughter, int numberOfHits) | ||
| void addMCParticle(int collIndex, ParticleStruct& fileParticles, int iParticle, uint8_t flags, int firstMother, int firstDaughter, int secondDaughter, int numberOfHits) | ||
| { | ||
| int mothers[2] = {firstMother, -1}; |
Collaborator
There was a problem hiding this comment.
The array of mother indices stores the first and last index similar to the daughter one, so what I did for with the decayer for one mother, is that i stored the index both first and last. This is what lets you loop over the mother array like we do in the sameMotherCheck
for (const auto& mcParticleMother : mcParticle.template mothers_as<aod::McParticles>())
It might still be okay to keep it like this but I would change it just in case
Suggested change
| int mothers[2] = {firstMother, -1}; | |
| int mothers[2] = {firstMother, firstMother}; |
|
|
||
| histos.fill(HIST("hV0Building"), 3.0); | ||
|
|
||
| // TODO: not all ACTS tracks have MC association, so this check is not possible for all candidates, fix is needed |
Collaborator
There was a problem hiding this comment.
This is maybe beyond the scope of this PR but would it not be possible to wrap this block into
if (posTrack.has_mcParticle() && negTrack.has_mcParticle()) {
// de-reference mcparticle
}
From what I remember, all ACTS tracks would not necessarily have an associated MC particle, but if that's the case, the index in aod::McTrackLabels could be set to -1 (maybe it is already). Because what has_mcParticle() checks if the index is greater than zero, so we would never enter this block if there is no associated mcParticle
Collaborator
|
Error while checking build/O2Physics/o2 for c7268d8 at 2026-08-18 17:53: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update of the translator to be consistent with the new ACTS output structure