Upd merge proofreading - #762
Merged
Merged
Conversation
Variables were left referencing the old bare parameter names after refactoring to accept MergeInferenceConfig, causing NameError at runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ataset - learned_merge_detection was referencing bare variable names from the old signature instead of merge_config fields, causing NameError at runtime - SearchDataset was missing node_segment_id(), which save_predictions() calls; __getattr__ delegation doesn't cover it since node_component_id is an array on the graph, not a method - Remove redundant save_parameters() call in pipeline; MLMergeProofreader.__call__ already handles it when save_result=True Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.