Fix WS2025 baselines and Machine Configuration MOF export - #104
Merged
Conversation
added 2 commits
July 27, 2026 22:20
Keep all 320/321/296 resources while canonicalizing Registry contracts, replacing read-only CSP paths, and translating compliance schemas to CEL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0836ff7c-06f5-4530-97fb-d69522abc79b
Emit portable module metadata, correlation groups, and canonical typed values, including empty-string fallback, with an audit-first packaging workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0836ff7c-06f5-4530-97fb-d69522abc79b
There was a problem hiding this comment.
Pull request overview
This PR rebuilds the Windows Server 2025 baseline overlays and updates ConfigForge’s Machine Configuration MOF export so the exported MOFs are portable for packaging while still supporting typed remediation.
Changes:
- Reworks WS2025 baselines to preserve resource counts/order, canonicalize Registry contracts (
REG_*, hive paths), and represent prior compliance schemas as CEL expressions. - Hardens Machine Configuration MOF export with portable module metadata (
ModuleVersion = "0.0.0"), correlation groups, and explicit typedValuefields. - Updates tests and docs to lock in WS2025 baseline invariants and document the new MOF packaging flow.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| public/_baselines/ws2025-workgroup-member.osc.yaml | Large WS2025 workgroup overlay rewrite: registry canonicalization + schema→CEL conversion + CSP→Registry/provider swaps. |
| packages/core/src/import-export/index.ts | MOF export enhancements: UUID/correlation group, portable module version placeholder, typed Value fields, and value extraction logic. |
| packages/core/src/import-export/index.test.ts | Extends MOF export regression coverage for module binding, correlation grouping, and typed Value behavior. |
| docs/src/user-guide/manifest-editor.md | Updates packaging instructions to resolve ModuleVersion = "0.0.0" before New-GuestConfigurationPackage and to default to Audit mode. |
| docs/src/changelog.md | Adds an Unreleased entry summarizing WS2025 baseline rebuild and MOF export changes. |
| CHANGELOG.md | Adds an Unreleased “Fixed” entry for WS2025 baseline rebuild + MOF export portability changes. |
| apps/desktop/src/data/baseline-catalog.test.ts | Adds invariants/tests to ensure WS2025 overlays preserve counts, uniqueness, expression-only wrappers, and writable CSP path usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use a WebCrypto UUID fallback and make the two Workgroup zero-valued Registry controls explicitly remediating. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0836ff7c-06f5-4530-97fb-d69522abc79b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Known upstream limitation
Microsoft.OSConfig 1.3.11 audits packages successfully but has an upstream Set() serialization defect; public docs default to Audit until a fixed module is available.